← Back to issue list

features: reorganize overlay feature tests

View original Github issue

Metadata

Project
craft-parts
Number
#407
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI.

Suggested action: —

No scores available.

Issue body

Subsystems affected by the overlay feature should be tested with and without the feature enabled. Reorganize the unit test layout so that regular tests run with the feature disabled, and again with overlay enabled in `tests/unit/feature/overlay`, including feature-specific tests. Also fix the part environment setup so that the `CRAFT_OVERLAY` variable is only set when the overlay feature is enabled. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1604

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Reorganized overlay feature unit tests to run with the feature enabled and disabled, added feature-specific tests, and fixed the part environment setup so CRAFT_OVERLAY is only set when the overlay feature is enabled. Resolves CRAFT-1604.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#602 fix: enable overlays in _enable_craft_parts_features() rockcraft merged Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated.
78%
#110 feat: Support overlay imagecraft merged Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files.
78%
#299 feat: enable override-overlay imagecraft merged Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test.
77%
#349 test: add overlay plugin integration test imagecraft merged Merged following successful CI checks and dual reviewer approval. The update adds integration tests for overlay plugin commands and bumps the craft-parts dependency across eight files.
74%
#1472 feat: add override-overlay craft-parts merged Merged the override-overlay feature. Approved by two reviewers with 180 additions and 35 deletions across 10 files. Passed required CI checks and was successfully integrated into the codebase.
73%
#406 steps: handle overlay feature in step lists craft-parts merged Merged after reviewer approval and passing CI. The change updates step list logic to exclude the overlay step when the feature is disabled, modifying 10 files with 184 additions and 13 deletions.
72%
#592 fix: delay enabling the overlay feature rockcraft merged Merged fix for #585 that delays overlay feature enablement from module import to Project object creation. Approved by two reviewers, passed CI, and updated six files.
72%
#1035 feat: reconcile overlays and partition features craft-parts merged Merged. Implements simultaneous overlay and partition feature support, resolving issue #1028. Approved by three reviewers with passing CI. Further tests and refactoring will follow in a subsequent PR.
72%
#147 executor: update overlay package list (CRAFT-581) craft-parts merged Merged update to the overlay package list prior to lifecycle execution when overlays are enabled. Approved by reviewer, passed CI checks, and modified 4 files (+10/-1).
72%
#1190 fix(overlay): detect conflicts between overlay and install craft-parts merged Merged fix enhancing Stage step collision detection to account for overlay contents, preventing conflicts with install directories. Includes integration tests, passed all CI checks, and received approval from three reviewers.
72%