← Back to issue list

features: reorganize overlay feature tests

View original Github issue

Metadata

Project
craft-parts
Number
#407
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #407 (e87e8b66): reorganized overlay unit tests for disabled and enabled feature runs, and only set CRAFT_OVERLAY when overlay support is enabled.

Resolution: closed resolved

Reason: The pull request was merged as commit e87e8b66. Its changes reorganize overlay tests and guard CRAFT_OVERLAY behind Features().enable_overlay.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Subsystems affected by the overlay feature should be tested with and without the feature enabled. Reorganize the unit test layout so that regular tests run with the feature disabled, and again with overlay enabled in `tests/unit/feature/overlay`, including feature-specific tests. Also fix the part environment setup so that the `CRAFT_OVERLAY` variable is only set when the overlay feature is enabled. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1604

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #407 (e87e8b66): reorganized overlay unit tests for disabled and enabled feature runs, and only set CRAFT_OVERLAY when overlay support is enabled.
stealth/space-bunny-alpha — closed resolved Merged #407 (e87e8b66), reorganizing overlay unit tests to run with the feature enabled and disabled and setting CRAFT_OVERLAY only when overlay is enabled.
qwen/qwen3.6-35b-a3b — — Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Reorganized overlay feature unit tests to run with the feature enabled and disabled, added feature-specific tests, and fixed the part environment setup so CRAFT_OVERLAY is only set when the overlay feature is enabled. Resolves CRAFT-1604.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#367 features: introduce craft-parts features craft-parts merged Merged PR #367 via commit 16a81f95, introducing configurable craft-parts features and an overlay toggle that suppresses overlay action generation when disabled.
70%
#299 feat: enable override-overlay imagecraft merged Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.
70%