feat: enable override-overlay
Metadata
Current evaluation
Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test.
Suggested action: —
No scores available.
Issue body
Updates craft-parts to ~= 2.30 for `override-overlay` support.
Adds a part to spread test which uses override-overlay key.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated craft-parts to ~= 2.30 to enable override-overlay support and added a corresponding spread test part. The change passed all lint and test checks before integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates craft-parts to ~=2.30 to enable override-overlay support and adds a spread test part utilizing the new key. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #110 feat: Support overlay | imagecraft | merged | Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files. | |
| #1165 feat: enable override-overlay | rockcraft | merged | Merged. Updates craft-parts to enable the override-overlay key, replaces overlay-script in tests, and updates documentation. Reviewers approved the changes and confirmed upgrading sphinx-terminal resolves linting errors. All required checks passed before merge. | |
| #1472 feat: add override-overlay | craft-parts | merged | Merged the override-overlay feature. Approved by two reviewers with 180 additions and 35 deletions across 10 files. Passed required CI checks and was successfully integrated into the codebase. | |
| #602 fix: enable overlays in _enable_craft_parts_features() | rockcraft | merged | Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated. | |
| #349 test: add overlay plugin integration test | imagecraft | merged | Merged following successful CI checks and dual reviewer approval. The update adds integration tests for overlay plugin commands and bumps the craft-parts dependency across eight files. | |
| #367 features: introduce craft-parts features | craft-parts | merged | Successfully merged, introducing configurable features for craft-parts including an optional overlay feature to control action generation. Approved by reviewer, passed CI, and integrated after build retrigger. | |
| #407 features: reorganize overlay feature tests | craft-parts | merged | Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI. | |
| #336 features: introduce craft-parts features | craft-parts | merged | Merged pull request introducing a configurable feature system to craft-parts, including an initial overlay feature implementation. Approved by reviewer, passed CI, and merged with 620 additions and 12 deletions across 14 files. | |
| #1473 docs: add override-overlay | craft-parts | merged | Merged documentation update adding override-overlay. Approved by three reviewers and passed CI checks despite two failing edge tests. Changes span six files with 20 additions and 8 deletions. | |
| #362 feat: add a method to enable craft-parts Features | craft-application | merged | Merged a method for Application subclasses to enable craft-parts features at the correct initialization point, ensuring proper setup order for overlays and logging. Approved, passed CI, and changed 30 lines across two files. |