← Back to issue list

feat: enable override-overlay

View original Github issue

Metadata

Project
imagecraft
Number
#299
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.

Resolution: closed resolved

Reason: PR #299 was approved and merged as commit 6d283be. It enables override-overlay through the craft-parts upgrade and adds a spread test using the key.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updates craft-parts to ~= 2.30 for `override-overlay` support. Adds a part to spread test which uses override-overlay key. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.
stealth/space-bunny-alpha — closed resolved Merged in #299 (commit 6d283be), upgrading craft-parts to ~=2.30 and adding a spread test for override-overlay support.
qwen/qwen3.6-35b-a3b — — Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated craft-parts to ~= 2.30 to enable override-overlay support and added a corresponding spread test part. The change passed all lint and test checks before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1165 feat: enable override-overlay rockcraft merged Merged in rockcraft#1165 via commit 1024f092, enabling override-overlay, updating a spread test from overlay-script, and documenting the key.
83%
#113 overlay: add overlay support to parts (CRAFT-470) craft-parts merged Merged #113 via commit 2d90e608, adding overlay work-directory definitions, overlay subdirectory properties, and detection of overlay parameters and visibility for CRAFT-470.
77%
#367 features: introduce craft-parts features craft-parts merged Merged PR #367 via commit 16a81f95, introducing configurable craft-parts features and an overlay toggle that suppresses overlay action generation when disabled.
76%
#1472 feat: add override-overlay craft-parts merged Merged #1472 (43dc8484), adding override-overlay scriptlets that run during the overlay step in a chroot, with validation and tests.
76%
#110 feat: Support overlay imagecraft merged Merged in imagecraft#110 (00f1348), enabling overlays and empty bases with spread coverage for overlays combined with partitions; fixes #98.
75%
#1415 feat: add override-overlay craft-parts merged Merged override-overlay support via #1472 (43dc8484), adding chrooted scriptlets, validation, mounts, hashing, and tests; docs followed in #1473 for 2.30.0.
75%
#1473 docs: add override-overlay craft-parts merged Merged into main as #1473 (commit 1b2b7d5a), documenting the override-overlay key and recording the feature introduced by #1472 in the changelog.
75%
#602 fix: enable overlays in _enable_craft_parts_features() rockcraft merged Merged #602 (commit 86153dcc), enabling Craft Parts overlays during Rockcraft initialization via Features(enable_overlay=True).
74%
#1035 feat: reconcile overlays and partition features craft-parts merged Merged PR #1035 at commit b575539e, enabling overlay and partition features simultaneously and fixing canonical/craft-parts#1028.
73%
#336 features: introduce craft-parts features craft-parts merged Feature controls landed via canonical/craft-parts#367 in commit 16a81f95, adding configurable features and suppression of overlay actions when the overlay feature is disabled.
73%