← Back to issue list

partitions: make partitions optional in ProjectDirs

View original Github issue

Metadata

Project
craft-parts
Number
#528
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #528 made ProjectDirs.partitions optional; commit 545f82c9 records the resolution after approval by two reviewers.

Resolution: closed resolved

Reason: PR #528 was merged into the project in commit 545f82c9. The change makes the partitions argument optional and received approval from two reviewers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #528 made ProjectDirs.partitions optional; commit 545f82c9 records the resolution after approval by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #528, making ProjectDirs.partitions optional in commit 545f82c9 after approval from two reviewers.
qwen/qwen3.6-35b-a3b — — Made partitions optional in ProjectDirs. Merged following approval from two reviewers, updating eight files (+170/-114 lines). Unresolved review comments and unrelated pyright linting changes did not block integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged the update making partitions optional in ProjectDirs. Unrelated linting failures from a pyright version bump were acknowledged. The change was successfully integrated.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#517 (confidence 85%)

    The preceding partition feature introduced the functionality that PR #528 made optional in ProjectDirs.

Related issues

Issue Project State Summary Similarity
#763 partitions feature documentation craft-parts merged Merged developer-facing partitions documentation in commit cdcc9dbc, completing CRAFT-3030 after approval by two reviewers.
74%
#489 partitions: add feature and validation craft-parts merged Merged as commit d363fa7c, adding the opt-in partitions feature to LifecycleManager/Dirs, partition name validation with new partition errors, and integration tests for CRAFT-1843. Follow-up PRs #493, #497 and #517 extended it.
72%
#652 feat(partitions): clean partition directories craft-parts merged Merged #652 via commit 797109e8, adding partition-directory cleanup when partitions are enabled and fixing #634 (CRAFT-2417).
71%