← Back to issue list

packages: don't write info logs in overlays

View original Github issue

Metadata

Project
craft-parts
Number
#535
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #535 via 56f25859: overlay subprocess messages now use debug, while the main process reports package fetching, avoiding chroot/spinner deadlocks.

Resolution: closed resolved

Reason: PR #535 was approved and merged. Commit 56f25859 downgraded overlay subprocess logging from info to debug and moved user-facing fetch progress to the main process, preventing the described deadlock.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit is a workaround for a current bad interaction between the way we perform overlay operations (a chroot in a multiprocess-created subprocess) and the way craft applications indicate progress on the cli (a spinner in a thread). The consequence of the bad interaction is that trying to write an info message to the terminal ends up deadlocking the main thread in the subprocess because the thread that could unblock it does not exist. Instead, log the message as 'debug' instead of 'info', and add a main- process-side 'info' message to communicate that overlay packages are being fetched. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #535 via 56f25859: overlay subprocess messages now use debug, while the main process reports package fetching, avoiding chroot/spinner deadlocks.
stealth/space-bunny-alpha — closed resolved Merged #535: overlay subprocess logging was changed from info to debug, with progress reported from the main process, to avoid spinner-related deadlocks during chroot operations.
qwen/qwen3.6-35b-a3b — — Merged a fix that downgrades overlay package logging from info to debug to prevent terminal deadlocks during chroot subprocess operations. A main-process info message replaces it. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix preventing terminal deadlocks during overlay operations. Subprocess log messages were downgraded from info to debug, with a main-process info message added to track package fetching progress.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#536 packages: don't write info logs in overlays (#535) craft-parts merged Merged PR #536 via 0da2e20d, lowering overlay subprocess fetch logs to debug and moving progress reporting to the main process to avoid spinner deadlocks.
91%