← Back to issue list

packages: don't write info logs in overlays (#535)

View original Github issue

Metadata

Project
craft-parts
Number
#536
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #536 via 0da2e20d, lowering overlay subprocess fetch logs to debug and moving progress reporting to the main process to avoid spinner deadlocks.

Resolution: closed resolved

Reason: PR #536 landed as commit 0da2e20d. It replaced overlay subprocess info logging with debug logging and added main-process info reporting to prevent the documented deadlock.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit is a workaround for a current bad interaction between the way we perform overlay operations (a chroot in a multiprocess-created subprocess) and the way craft applications indicate progress on the cli (a spinner in a thread). The consequence of the bad interaction is that trying to write an info message to the terminal ends up deadlocking the main thread in the subprocess because the thread that could unblock it does not exist. Instead, log the message as 'debug' instead of 'info', and add a main- process-side 'info' message to communicate that overlay packages are being fetched. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #536 via 0da2e20d, lowering overlay subprocess fetch logs to debug and moving progress reporting to the main process to avoid spinner deadlocks.
stealth/space-bunny-alpha — closed resolved Merged #535: overlay fetch logs were lowered to debug to prevent subprocess spinner deadlocks, with progress reporting moved to the main process.
qwen/qwen3.6-35b-a3b — — Merged a fix for a subprocess deadlock during package overlay operations. Downgrading terminal info logs to debug and moving progress updates to the main process prevents thread blocking. Approved by reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged PR #535 resolves a deadlock in subprocess overlay operations caused by CLI spinner interactions. The fix changes log output from info to debug and adds a main-process info message to maintain user feedback without blocking execution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#535 packages: don't write info logs in overlays craft-parts merged Merged in #535 via 56f25859: overlay subprocess messages now use debug, while the main process reports package fetching, avoiding chroot/spinner deadlocks.
91%