← Back to issue list

packages: don't write info logs in overlays (#535)

View original Github issue

Metadata

Project
craft-parts
Number
#536
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for a subprocess deadlock during package overlay operations. Downgrading terminal info logs to debug and moving progress updates to the main process prevents thread blocking. Approved by reviewers and passed CI.

Suggested action:

No scores available.

Issue body

This commit is a workaround for a current bad interaction between the way we perform overlay operations (a chroot in a multiprocess-created subprocess) and the way craft applications indicate progress on the cli (a spinner in a thread). The consequence of the bad interaction is that trying to write an info message to the terminal ends up deadlocking the main thread in the subprocess because the thread that could unblock it does not exist. Instead, log the message as 'debug' instead of 'info', and add a main- process-side 'info' message to communicate that overlay packages are being fetched. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for a subprocess deadlock during package overlay operations. Downgrading terminal info logs to debug and moving progress updates to the main process prevents thread blocking. Approved by reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged PR #535 resolves a deadlock in subprocess overlay operations caused by CLI spinner interactions. The fix changes log output from info to debug and adds a main-process info message to maintain user feedback without blocking execution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#535 packages: don't write info logs in overlays craft-parts merged Merged a fix that downgrades overlay package logging from info to debug to prevent terminal deadlocks during chroot subprocess operations. A main-process info message replaces it. Approved by two reviewers and passed CI.
93%
#147 executor: update overlay package list (CRAFT-581) craft-parts merged Merged update to the overlay package list prior to lifecycle execution when overlays are enabled. Approved by reviewer, passed CI checks, and modified 4 files (+10/-1).
70%