fix(environment): sort project variables before replacement
Metadata
Current evaluation
Merged #554 (438fa857) sorted project variables by descending name length, fixing premature triplet expansion; the fix reached mainline via #571 (bdc12ec4) and resolved #541.
Resolution: closed resolved
Reason: PR #554 was merged as 438fa857, ensuring specific build-on/build-for triplet variables are replaced before their shorter prefixes. The same fix reached mainline through PR #571 as bdc12ec4, and the PR explicitly states that it fixes #541.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Sort project variables before replacement, such that `$CRAFT_ARCH_TRIPLET_BUILD_{ON|FOR}` are replaced before `$CRAFT_ARCH_TRIPLET`.
Fixes #541
(CRAFT-2029)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #554 (438fa857) sorted project variables by descending name length, fixing premature triplet expansion; the fix reached mainline via #571 (bdc12ec4) and resolved #541. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-parts #554 (438fa857; mainline bdc12ec4 via #571), sorting project variables so specific build-on/build-for triplets are replaced before shorter prefixes; fixes #541. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix sorting project variables before replacement to ensure specific arch triplet variables are processed first. Approved by two reviewers, passed CI, and resolves #541. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer mr-cal. Sorts project variables before replacement so CRAFT_ARCH_TRIPLET_BUILD_ON and FOR are processed first, fixing issue #541. An out-of-scope comment was left unresolved for potential future tracking. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#541
(confidence 100%)
Premature architecture-triplet expansion bug explicitly fixed by this PR.
-
Related To:
canonical/craft-parts#571
(confidence 98%)
Merged the same variable-ordering fix into mainline as bdc12ec4.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #571 fix(environment): sort project variables before replacement | craft-parts | merged | Merged in canonical/craft-parts#571 as bdc12ec4, sorting project variables so specific build-on/build-for names are replaced before shorter prefixes. | |
| #4366 fix(environment): sort core20 project variables before replacement | snapcraft | merged | Merged PR #4366 in commit ae891d1d, sorting core20 project variables so BUILD_ON/BUILD_FOR values expand before SNAPCRAFT_ARCH_TRIPLET and fixing #4363. |