fix(environment): sort project variables before replacement
Metadata
Current evaluation
Merged in canonical/craft-parts#571 as bdc12ec4, sorting project variables so specific build-on/build-for names are replaced before shorter prefixes.
Resolution: closed resolved
Reason: PR #571 merged as commit bdc12ec4, carrying the #554 fix from 438fa857. It prevents premature replacement of longer project-variable names by shorter prefixes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-parts#571 as bdc12ec4, sorting project variables so specific build-on/build-for names are replaced before shorter prefixes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-parts#571 (commit bdc12ec4), sorting project variables before environment replacement so more specific variables resolve correctly. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that sorts project variables prior to environment replacement, ensuring correct resolution. Approved by one reviewer, passed CI, and modified five files with 189 additions and one deletion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that sorts project variables before environment replacement to ensure deterministic configuration resolution. The change was integrated by a maintainer without additional discussion. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-parts#541
(confidence 100%)
The ordering change fixes premature expansion of build-on/build-for project variables.
-
Related To:
canonical/craft-parts#554
(confidence 99%)
Original fix merged as 438fa857; bdc12ec4 carries the change through #571.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #554 fix(environment): sort project variables before replacement | craft-parts | merged | Merged #554 (438fa857) sorted project variables by descending name length, fixing premature triplet expansion; the fix reached mainline via #571 (bdc12ec4) and resolved #541. | |
| #4366 fix(environment): sort core20 project variables before replacement | snapcraft | merged | Merged PR #4366 in commit ae891d1d, sorting core20 project variables so BUILD_ON/BUILD_FOR values expand before SNAPCRAFT_ARCH_TRIPLET and fixing #4363. | |
| #541 Premature parts environment variable expansion | craft-parts | closed | Fixed premature CRAFT_ARCH_TRIPLET_BUILD_FOR expansion by sorting variable replacements; merged in craft-parts#554 (438fa857). |