← Back to issue list

feat: add a utility function that determines whether a part has slices

View original Github issue

Metadata

Project
craft-parts
Number
#637
Type
pull request
State
closed
Author
linostar
Labels
—
Created
Updated
Closed

Current evaluation

PR #637 (part_has_slices utility) sat unmerged with change requests; author closed it 2024-11-20 in favor of #904 (merged 941164e1), with the helpers finally landing in #914 (commit 1062a468).

Resolution: closed superseded

Reason: The author closed the unmerged PR in favour of #904, which was merged in commit 941164e1; the part_has_slices/part_has_chisel_as_build_snap helpers were ultimately added by #914 (commit 1062a468).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- A utility function is needed in rockcraft to determine whether parts has slices in them. Instead of implementing such a function in rockcraft, it is better to implement it in craft-parts instead.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #637 (part_has_slices utility) sat unmerged with change requests; author closed it 2024-11-20 in favor of #904 (merged 941164e1), with the helpers finally landing in #914 (commit 1062a468).
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of craft-parts#904, merged as 941164e1. Slice-detection functionality was later added by craft-parts#914, merged as 1062a468.
qwen/qwen3.6-35b-a3b — — Closed in favor of PR #904. The utility function to detect part slices was superseded by an alternative implementation. Review feedback was incorporated, but the changes were ultimately consolidated into the referenced pull request.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by PR #904. The proposed utility function to detect slices in parts was abandoned in favor of an alternative implementation.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#904 (confidence 96%)

    Author explicitly closed #637 in favour of #904, merged as commit 941164e1 (chisel build snap when stage-packages contain slices).

  • Likely Fixed By: canonical/craft-parts#914 (confidence 95%)

    Merged commit 1062a468 adds part_has_slices and part_has_chisel_as_build_snap, delivering the functionality #637 proposed.

  • Related To: canonical/rockcraft#464 (confidence 70%)

    Rockcraft PR cited by the author as the motivation for moving this helper into craft-parts.

Related issues

Issue Project State Summary Similarity
#914 feat: add funcs part_has_slices and part_has_chisel_as_build_snap craft-parts merged Merged PR #914 in commit 1062a468, adding part_has_slices and part_has_chisel_as_build_snap for inspecting part dictionaries without constructing PartSpec objects.
73%