← Back to issue list

feat: add chisel as a build snap when stage-packages contain slices

View original Github issue

Metadata

Project
craft-parts
Number
#904
Type
pull request
State
merged
Author
linostar
Labels
—
Created
Updated
Closed

Current evaluation

Merged #904 via commit 941164e1, adding chisel@latest/stable only when stage-packages contain slices and no part already declares chisel.

Resolution: closed resolved

Reason: PR #904 was merged as commit 941164e1. The lifecycle manager now detects sliced stage-packages, avoids duplicate chisel declarations, and installs the build snap only when needed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This PR aims to stop chisel from being unnecessarily installed in the Rockcraft snap. It does that by having chisel as a build snap only when the following conditions are met: - there is at least one `part` that has slices in its `stage-packages` - there is no `part` that has chisel in its `build-snaps`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #904 via commit 941164e1, adding chisel@latest/stable only when stage-packages contain slices and no part already declares chisel.
stealth/space-bunny-alpha — closed resolved Merged (commit 941164e1): craft-parts now adds chisel@latest/stable as a build snap only when a part has slices and no part declares chisel in build-snaps, avoiding unneeded chisel installs in e.g. Rockcraft.
stealth/space-bunny-alpha — closed resolved Merged in craft-parts#904: Chisel is now a build snap only when stage-packages contain slices and no part already declares it.
qwen/qwen3.6-35b-a3b — — Merged. Conditionally installs chisel as a build snap only when stage-packages contain slices and no part already declares it, preventing unnecessary installation in the Rockcraft snap. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged after review. Conditionally adds chisel as a build snap only when stage-packages contain slices and chisel is not already declared, preventing unnecessary installation in the Rockcraft snap.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#649 Install chisel if parts use slices craft-parts closed Implemented as requested: PR #904 (commit 941164e1) makes craft-parts append chisel@latest/stable to extra build snaps when any part has stage-packages/build-packages slices. Later #914 added part_has_chisel_as_build_snap detection.
82%
#279 spec: add "stage-slices" for chisel slices craft-parts merged Merged PR #279, adding stage-slices so Chisel slices are declared separately from stage-packages; support is documented in Craft Parts 2.36.0.
79%
#84 Add chisel to rockcraft rockcraft merged Merged PR #84 as commit ddf018ce, adding Chisel to Rockcraft’s snap and enabling Chisel slices in stage-packages.
77%
#1737 fix: install chisel for build-slices craft-parts closed Merged #1737 as commit 46fb937b: Chisel is now installed automatically when any part declares build-slices. The fix is recorded in craft-parts 2.37.1.
73%
#281 unpack chisel slices craft-parts merged Merged PR #281 as commit 17c119ea, adding Chisel slice unpacking by passing slices from pull to build via PullState, with CI integration coverage.
73%
#4441 feat: enable chisel snapcraft merged Merged #4441 via commit c7ebc342b, enabling Chisel across three files after approval from two reviewers.
73%
#1538 feat(packages/deb): parse chisel manifests craft-parts merged Merged #1538 as 49a8824c, adding Chisel manifest parsing so stage-packages are filtered correctly for the chiseled Core 26 base.
73%
#4260 Allow chiseled stage-packages snapcraft closed Chiseled stage-packages support shipped in Snapcraft 8 through PR #4441, commit c7ebc342b.
72%
#4522 chore(deps): bump version of Chisel snapcraft merged Merged PR #4522, updating Snapcraft's staged Chisel dependency to v0.8.1 for compatibility with upcoming Chisel and chisel-releases provisioning changes.
70%
#1718 feat: cut build-slices in the prologue craft-parts closed Merged as commit 2adcb0c1. Executor prologue now collects build-slices from all parts, de-duplicates them into a single chisel cut, with a state file to skip unchanged re-cuts; unit and integration tests added.
70%