feat: add chisel as a build snap when stage-packages contain slices
Metadata
Current evaluation
Merged. Conditionally installs chisel as a build snap only when stage-packages contain slices and no part already declares it, preventing unnecessary installation in the Rockcraft snap. Approved by two reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This PR aims to stop chisel from being unnecessarily installed in the Rockcraft snap.
It does that by having chisel as a build snap only when the following conditions are met:
- there is at least one `part` that has slices in its `stage-packages`
- there is no `part` that has chisel in its `build-snaps`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Conditionally installs chisel as a build snap only when stage-packages contain slices and no part already declares it, preventing unnecessary installation in the Rockcraft snap. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after review. Conditionally adds chisel as a build snap only when stage-packages contain slices and chisel is not already declared, preventing unnecessary installation in the Rockcraft snap. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #17 build: drop chisel from rockcraft.yaml | snapcraft-rocks | merged | Merged after removing chisel from rockcraft.yaml to align the Snapcraft rock with standard Snapcraft capabilities, as Snapcraft 7 lacks support. Approved by two reviewers, passed CI, and modified three files. A v8-specific test suite will later restore the Chisel spread test. | |
| #914 feat: add funcs part_has_slices and part_has_chisel_as_build_snap | craft-parts | merged | Merged part_has_slices and part_has_chisel_as_build_snap to check part data for slices and chisel in build-snaps. Approved by two reviewers and passed CI, the +29/-1 change aids Rockcraft by avoiding PartSpec conversions. | |
| #279 spec: add "stage-slices" for chisel slices | craft-parts | merged | Merged the addition of a stage-slices specification to handle chisel slice naming conventions, which require underscores unlike standard .deb packages. Approved by one reviewer, modified two files, and resolved CRAFT-1329. | |
| #4260 Allow chiseled stage-packages | snapcraft | closed | Implemented chiseled stage-packages support in snapcraft 8, allowing chisel slices to reduce unneeded files and deduplicate packaging work. | |
| #84 Add chisel to rockcraft | rockcraft | merged | Merged after approval and passing CI. Integrated chisel into rockcraft to support chisel slices in stage-packages. Temporarily pinned craft-parts to a main branch commit pending an official release. Added a spread test for the dotnet-runtime-6.0_libs slice. | |
| #1538 feat(packages/deb): parse chisel manifests | craft-parts | merged | Squash-merged feature adding Chisel manifest parsing to the deb package handler. Filters stage-packages for Core26 by reading manifest files. Approved by two reviewers, passed CI checks, and unblocks downstream snapcraft issues. | |
| #464 Make chisel a build snap | rockcraft | closed | Superseded by PR #758. The change to make chisel a build snap instead of embedding it in rockcraft was closed without merging after delays for chisel's stable release and project ownership transfer. | |
| #649 Install chisel if parts use slices | craft-parts | closed | Automatically installs chisel when parts declare slices in stage-packages. Resolved and merged via pull request #904, centralizing the tool management within craft-parts. | |
| #1717 feat(part): add build-slices model | craft-parts | closed | Merged the addition of a build-slices Part property listing Chisel slices for the build root. The change introduces a new feature flag and validation logic. Approved by a reviewer and passed all CI checks. | |
| #18 build: readd chisel for snapcraft 8 | snapcraft-rocks | merged | Merged re-addition of Chisel support and spread tests for Snapcraft 8.x. The change also bumps Snapcraft to 8.0.2. Approved by two reviewers and integrated. |