parts: refactor to remove stored dictionary data
Metadata
Current evaluation
PR #7 (parts refactor to unmarshal spec data instead of storing dicts) was closed unmerged on 2021-04-07 by cmatsuoka with the comment "Superseded by PR #9", which reimplemented the change and was merged.
Resolution: closed superseded
Reason: The author closed PR #7 unmerged stating "Superseded by PR #9" (2021-04-07), noting it also conflicted with PR #6. PR #9 carried out the same pydantic-based parts unmarshalling and validation-before-population refactor and was merged, superseding #6–#8.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Refactor the parts definition to unmarshal parts specification data
instead of storing it. Validation should be done before populating the
spec object instead of relying on jsonschema validation.
This PR conflicts with PR #6.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #7 (parts refactor to unmarshal spec data instead of storing dicts) was closed unmerged on 2021-04-07 by cmatsuoka with the comment "Superseded by PR #9", which reimplemented the change and was merged. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR canonical/craft-parts#9, which replaced stored parts dictionaries with pydantic-based unmarshalling and pre-population validation. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded by PR #9, which replaced stored dictionary data with pydantic-based parts specification unmarshalling and validation. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #9. Refactored parts definitions to unmarshal specification data instead of storing it, validating before populating the spec object. Closed without merging due to conflicts with PR #6 and replaced by a subsequent PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Refactored parts definition to unmarshal specification data instead of storing it. The pull request was closed and superseded by PR #9, which incorporated the changes and resolved conflicts with PR #6. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-parts#9
(confidence 97%)
Maintainer comment on #7 states it is superseded by PR #9, which was merged with the same parts-unmarshalling refactor.
-
Related To:
canonical/craft-parts#6
(confidence 80%)
PR body notes #7 conflicts with PR #6; #9 superseded the #6–#8 series.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #9 parts: refactor to remove stored dictionary data | craft-parts | merged | Merged PR #9 replaced stored parts dictionaries with pydantic-based specification unmarshalling and validation, superseding PRs #6–#8. |