parts: refactor to remove stored dictionary data
Metadata
Current evaluation
Merged PR #9 replaced stored parts dictionaries with pydantic-based specification unmarshalling and validation, superseding PRs #6–#8.
Resolution: closed resolved
Reason: PR #9 was merged after approval by two reviewers, delivering the parts-data refactor. Its description explicitly states that it replaces PRs #6, #7, and #8.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Refactor the parts definition to unmarshal parts specification data
instead of storing it. Data is validated using pydantic based on
Python type annotations.
This PR replaces PRs #6, #7, and #8.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #9 replaced stored parts dictionaries with pydantic-based specification unmarshalling and validation, superseding PRs #6–#8. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged via 5ec52d53 (implementation bbd50615), replacing stored part dictionaries with pydantic-based specification unmarshalling and annotation validation; superseded PRs #6–#8. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #9 refactored parts definitions to unmarshal specification data with pydantic validation, replacing stored dictionaries and superseding PRs #6–#8. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor replacing stored dictionary data in parts definitions with pydantic-based unmarshalling. Approved by two reviewers and passing CI, this supersedes PRs #6, #7, and #8, updating five files to streamline data handling. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor replacing stored dictionary data in parts definitions with unmarshalled specification data validated via pydantic. This update consolidates and replaces PRs #6, #7, and #8. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#6
(confidence 100%)
The schema and validator PR was closed unmerged after #9 replaced it.
-
Related To:
canonical/craft-parts#7
(confidence 100%)
The earlier parts-data refactor was closed unmerged and superseded by #9.
-
Related To:
canonical/craft-parts#8
(confidence 100%)
Its formatting utilities were incorporated into the merged replacement PR #9.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #7 parts: refactor to remove stored dictionary data | craft-parts | closed | PR #7 (parts refactor to unmarshal spec data instead of storing dicts) was closed unmerged on 2021-04-07 by cmatsuoka with the comment "Superseded by PR #9", which reimplemented the change and was merged. |