← Back to issue list

`source-*` pydantic models

View original Github issue

Metadata

Project
craft-parts
Number
#708
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed as done: maintainer lengau linked merged PR canonical/craft-parts#776 (commit 3d880869), which added pydantic models for every source type and their tagged union, built on prerequisite PR #775.

Resolution: closed resolved

Reason: Maintainer lengau closed the issue on 2024-07-26 with "Done in #776"; PR canonical/craft-parts#776 "feat: add pydantic models for all sources" was merged as commit 3d880869, adding per-source pydantic models and a tagged union enabling whole-part JSON schema generation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Create pydantic models that can be verified for different source types, and a tagged union type for all source types. ### Why it needs to get done We should be able to use pydantic to generate schema models.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Closed as done: maintainer lengau linked merged PR canonical/craft-parts#776 (commit 3d880869), which added pydantic models for every source type and their tagged union, built on prerequisite PR #775.
stealth/space-bunny-alpha — closed resolved Added Pydantic models for all source types and their tagged union in merged PR canonical/craft-parts#776 (commit 3d880869).
qwen/qwen3.6-35b-a3b — — Implemented pydantic models for source types and a tagged union type to enable schema generation. Resolved and merged via pull request #776.
qwen/qwen3.6-35b-a3b — — Implemented pydantic models for different source types and a tagged union. Resolved by merging pull request #776.
qwen/qwen3.6-35b-a3b — — Implemented pydantic models for source types and a tagged union to enable schema generation. Resolved and closed via merge of pull request #776.
qwen3.6-35b-a3b-mtp-q6 — — Implemented pydantic models for source types and a tagged union type. The request was fulfilled and merged in pull request #776.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#776 (confidence 97%)

    Merged PR cited by the closing maintainer comment; adds pydantic models for all sources and their tagged union.

  • Related To: canonical/craft-parts#775 (confidence 80%)

    Prerequisite PR 'chore!: restructure plugin models' (commit 029f1ad6) that made unmarshal reusable, which #776 builds upon.

Related issues

Issue Project State Summary Similarity
#776 feat: add pydantic models for all sources craft-parts merged Merged PR #776 added Pydantic models for every source, enabling whole-part JSON schema generation and building on prerequisite PR #775.
76%