← Back to issue list

sources: add 7z source handler

View original Github issue

Metadata

Project
craft-parts
Number
#740
Type
pull request
State
merged
Author
liushuyu
Labels
—
Created
Updated
Closed

Current evaluation

Merged 7z source-handler support in commit 94e401ed, replacing unmerged #232 and using maintained 7zip, Ruff annotations, and 7z's -o option.

Resolution: closed resolved

Reason: PR #740 was merged as commit 94e401ed, adding 7z source handling. It superseded unmerged PR #232 and incorporated its updated implementation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Allow parts to specify 7z sources. Based on the implementation from Snapcraft. Supersedes #232. The changes from #232 include: - Use better maintained upstream 7zip version instead of defunct `p7zip` package - Switch linter annotations from Pylint to Ruff - Use `-o` path option instead of using `cwd=` option in `subprocess.run`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged 7z source-handler support in commit 94e401ed, replacing unmerged #232 and using maintained 7zip, Ruff annotations, and 7z's -o option.
stealth/space-bunny-alpha — closed resolved Merged 7z source support in commit 94e401ed (PR #740), replacing the unmerged #232 and using 7zip, Ruff, and -o.
qwen/qwen3.6-35b-a3b — — Added a 7z source handler for parts. Supersedes #232, uses upstream 7zip, switches linting to Ruff, and updates subprocess calls. Merged after approval by three reviewers and CI fixes.
qwen3.6-35b-a3b-mtp-q6 — — Successfully merged. Adds a 7z source handler for parts, replacing p7zip with upstream 7zip, switching linting to Ruff, and fixing subprocess path handling. Supersedes #232. CI errors were resolved prior to merge.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#232 (confidence 100%)

    PR #740 explicitly superseded #232, which remained unmerged.

Related issues

Issue Project State Summary Similarity
#232 sources: add 7z source handler craft-parts closed PR #232 (7z source handler) was never merged and was closed as superseded by canonical/craft-parts#740, which landed the feature in commit 94e401ed (craft_parts/sources/sevenzip_source.py).
82%
#1168 sources: add support for 7-zip files snapcraft merged Merged PR #1168 added .7z source support using libarchive, with tests, in squashed commit a2beca258.
79%