← Back to issue list

sources: add 7z source handler

View original Github issue

Metadata

Project
craft-parts
Number
#232
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #232 (7z source handler) was never merged and was closed as superseded by canonical/craft-parts#740, which landed the feature in commit 94e401ed (craft_parts/sources/sevenzip_source.py).

Resolution: closed superseded

Reason: The PR's own final comment reads "Superseded by #740", and repo history confirms sevenzip_source.py originates in commit 94e401ed ("sources: add 7z source handler (#740)"), not #232. The functionality shipped via the merged #740, later refined by #1515.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Allow parts to specify 7z sources. Based on the implementation from Snapcraft. Co-authored-by: Tim Süberkrüb <dev@timsueberkrueb.io> Co-authored-by: Kyle Fazzari <kyrofa@ubuntu.com> Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #232 (7z source handler) was never merged and was closed as superseded by canonical/craft-parts#740, which landed the feature in commit 94e401ed (craft_parts/sources/sevenzip_source.py).
stealth/space-bunny-alpha — closed superseded 7z source support remained unmerged in #232 and was superseded by #740, which landed as commit 94e401ed.
qwen/qwen3.6-35b-a3b — — Adding a 7z source handler was closed and superseded by PR #740. The original implementation was rebased on main but never merged, as a replacement PR handles the feature.
qwen3.6-35b-a3b-mtp-q6 — — The 7z source handler addition was closed and superseded by PR #740. After rebasing on main in November 2022, the changes were replaced by a newer implementation.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#740 (confidence 98%)

    Stated in the closing comment and confirmed by commit 94e401ed, which introduced craft_parts/sources/sevenzip_source.py.

  • Related To: canonical/craft-parts#1515 (confidence 75%)

    Later follow-up (commit c3aec9c6) fixing 7z source-type mapping/docs, downstream of the #740 implementation.

Related issues

Issue Project State Summary Similarity
#740 sources: add 7z source handler craft-parts merged Merged 7z source-handler support in commit 94e401ed, replacing unmerged #232 and using maintained 7zip, Ruff annotations, and 7z's -o option.
82%
#1443 7zip sources are broken and undocumented craft-parts closed Fixed in canonical/craft-parts#1515 (commit c3aec9c6), which corrected 7z source handling and documented the supported source type.
78%
#212 sources: add zip file source handler craft-parts merged Merged PR #212 (merge commit 043b3da8, implementation a9b32b31) adding a ZipSource handler in craft_parts/sources/zip_source.py so parts can use 'source-type: zip', with unit tests and docs.
75%
#1514 fix: 7z(ip) sources support (#1443) craft-parts closed 7z/7z-IP support was delivered by merged PR canonical/craft-parts#1515 in commit c3aec9c6; PR #1514 closed as superseded.
74%
#1168 sources: add support for 7-zip files snapcraft merged Merged PR #1168 added .7z source support using libarchive, with tests, in squashed commit a2beca258.
72%
#1515 fix: 7z(ip) sources support (#1443) craft-parts merged Merged PR #1515 as commit c3aec9c6, correcting 7z/IP source-type mapping and documenting 7z sources; fixes canonical/craft-parts#1443.
72%