← Back to issue list

chore: simplify extract_plugin_properties

View original Github issue

Metadata

Project
craft-parts
Number
#787
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #787 in commit f689ed84, simplifying extract_plugin_properties to address Ruff 0.5's for-loop lint complaint.

Resolution: closed resolved

Reason: PR #787 was merged, and commit f689ed84 implements the requested Ruff 0.5 cleanup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Ruff 0.5 complains about the for loop - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #787 in commit f689ed84, simplifying extract_plugin_properties to address Ruff 0.5's for-loop lint complaint.
stealth/space-bunny-alpha — closed resolved Merged PR #787 as commit f689ed84, simplifying extract_plugin_properties to resolve Ruff 0.5's loop lint complaint.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#787, simplifying extract_plugin_properties to resolve Ruff 0.5’s for-loop lint complaint.
qwen/qwen3.6-35b-a3b — — Merged simplification of extract_plugin_properties to address a Ruff 0.5 linting warning for a for loop. Approved by two reviewers, passed CI, and reduced code by six lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged to simplify extract_plugin_properties, resolving a Ruff 0.5 linting warning regarding a for loop.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
71%
#775 chore!: restructure plugin models craft-parts merged Merged PR #775 as commit 029f1ad6, removing PluginModel, consolidating plugin property models, and making unmarshal reusable across plugins.
71%