feat: tweaks to address user feedback before merging to main
Metadata
Current evaluation
Closed without merging, likely abandoned or superseded due to lack of review and CI checks. The PR proposed poetry plugin tweaks addressing user feedback, including function renaming and dependency handling adjustments.
Suggested action: —
No scores available.
Issue body
This addresses some user feedback about the poetry plugin:
1. Replaces `poetry_with` with `poetry_dependency_groups`
2. Uses the `--only` export arg for poetry with dep groups
3. Pip installs without dependencies (should behave identically as poetry calculates these dependencies)
4. Tests that indirect dependencies are included
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging, likely abandoned or superseded due to lack of review and CI checks. The PR proposed poetry plugin tweaks addressing user feedback, including function renaming and dependency handling adjustments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to main after addressing user feedback for the poetry plugin. Changes include renaming poetry_with to poetry_dependency_groups, adjusting export args, modifying pip install behavior, and verifying indirect dependency inclusion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #818 [experimental] poetry plugin | craft-parts | closed | Closed and superseded by PR #820. The experimental poetry plugin was abandoned in favor of a new implementation. | |
| #830 feat(docs): add poetry plugin reference | craft-parts | merged | Merged after approval by two reviewers. The change adds documentation for a poetry plugin reference, introducing 107 lines across three files. The update was integrated into the main branch without further discussion. | |
| #1840 [EXPERIMENTAL]: poetry plugin | charmcraft | closed | Superseded by pull request #1899, which implemented the experimental poetry plugin. The original PR was closed without merging. |