feat: tweaks to address user feedback before merging to main
Metadata
Current evaluation
PR #828 was closed unmerged after 767 days of inactivity; the Poetry plugin still uses poetry_with and --with, so its dependency-group export rework did not land.
Resolution: closed stale
Reason: PR #828 had no reviewers, CI runs, comments, or later activity and was never merged. Current source still defines poetry_with and emits --with, confirming the proposed rename and dependency-group export changes did not land.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This addresses some user feedback about the poetry plugin:
1. Replaces `poetry_with` with `poetry_dependency_groups`
2. Uses the `--only` export arg for poetry with dep groups
3. Pip installs without dependencies (should behave identically as poetry calculates these dependencies)
4. Tests that indirect dependencies are included
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #828 was closed unmerged after 767 days of inactivity; the Poetry plugin still uses poetry_with and --with, so its dependency-group export rework did not land. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after 759 days; proposed Poetry dependency-group, export, and pip-install refinements were abandoned. | |
| stealth/space-bunny-alpha | — | closed stale | Poetry plugin feedback PR #828 was closed unmerged and abandoned after 759 days; its dependency-group, export, and pip-install tweaks were not included. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging, likely abandoned or superseded due to lack of review and CI checks. The PR proposed poetry plugin tweaks addressing user feedback, including function renaming and dependency handling adjustments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to main after addressing user feedback for the poetry plugin. Changes include renaming poetry_with to poetry_dependency_groups, adjusting export args, modifying pip install behavior, and verifying indirect dependency inclusion. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#820
(confidence 90%)
The merged Poetry plugin introduction established the poetry_with and --with behavior that remains.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #818 [experimental] poetry plugin | craft-parts | closed | Closed unmerged by maintainer lengau on 2024-08-23 as superseded by #820, which landed the Poetry plugin via commit 8b0d76c8 (feat(plugin): add poetry plugin). | |
| #940 feat(plugins/poetry): add poetry and pip extra args | craft-parts | merged | Merged into main as commit e55d6bcd. PR #940 added poetry-export-extra-args and poetry-pip-extra-args properties to the Poetry plugin for advanced users, with docs and unit tests. | |
| #820 feat(plugin): add poetry plugin | craft-parts | merged | Merged Poetry plugin support in commit 8b0d76c8, adding first-class build-system handling via poetry install and resolving #707. | |
| #707 `poetry` Python plugin | craft-parts | closed | Poetry plugin feature request implemented: PR #820 ("feat(plugin): add poetry plugin", commit 8b0d76c8) merged, later documented in #830 and fixed in #960. Issue closed by mr-cal on 2025-07-09 with "Completed via #820". | |
| #829 chore: merge poetry plugin feature branch to main | craft-parts | merged | Merged the Poetry feature branch into main, integrating the base Python plugin from #819 (13cfedfb) and Poetry support from #820 (8b0d76c8). |