← Back to issue list

feat(plugins/poetry): add poetry and pip extra args

View original Github issue

Metadata

Project
craft-parts
Number
#940
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main as commit e55d6bcd. PR #940 added poetry-export-extra-args and poetry-pip-extra-args properties to the Poetry plugin for advanced users, with docs and unit tests.

Resolution: closed resolved

Reason: PR #940 was merged by maintainer lengau after approval from 3 reviewers, landing as commit e55d6bcd. Both new plugin properties (poetry_export_extra_args, poetry_pip_extra_args) are present in craft_parts/plugins/poetry_plugin.py, documented in docs/common/craft-parts/reference/plugins/poetry_plugin.rst, and exercised by tests/unit/plugins/test_poetry_plugin.py.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This allows more customisation of the poetry and pip commands for advanced users. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main as commit e55d6bcd. PR #940 added poetry-export-extra-args and poetry-pip-extra-args properties to the Poetry plugin for advanced users, with docs and unit tests.
stealth/space-bunny-alpha — closed resolved Merged PR #940 (commit e55d6bcd) added extra arguments for Poetry and pip commands, enabling advanced customization.
qwen/qwen3.6-35b-a3b — — Merged feature adding extra arguments for poetry and pip commands to enable advanced user customization. Approved by three reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged feature adding extra arguments for poetry and pip commands, enabling advanced customization. Integrated directly by maintainer lengau without additional review comments.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#946 (confidence 55%)

    Nearby docs PR (741da635) also touching the poetry plugin docs in the same period, but concerns the poetry-with field rather than extra args.

Related issues

Issue Project State Summary Similarity
#932 Add `poetry-export-extra-args` and `poetry-pip-extra-args` options to the poetry plugin craft-parts closed Added Poetry export and pip-install extra arguments in merged PR #940 (commit e55d6bcd), released in craft-parts 2.2.0.
86%
#820 feat(plugin): add poetry plugin craft-parts merged Merged Poetry plugin support in commit 8b0d76c8, adding first-class build-system handling via poetry install and resolving #707.
77%
#830 feat(docs): add poetry plugin reference craft-parts merged Merged PR #830 as commit aec88860, adding Poetry plugin reference documentation across three files (+107/-1), following the plugin introduced in #820.
76%
#707 `poetry` Python plugin craft-parts closed Poetry plugin feature request implemented: PR #820 ("feat(plugin): add poetry plugin", commit 8b0d76c8) merged, later documented in #830 and fixed in #960. Issue closed by mr-cal on 2025-07-09 with "Completed via #820".
75%
#1840 [EXPERIMENTAL]: poetry plugin charmcraft closed Experimental Poetry plugin PR closed unmerged in favour of charmcraft#1899, merged as commit 8b748f3e, adding charmcraft/parts/plugins/_poetry.py and _python.py with charm-oriented defaults.
73%
#1940 feat(docs): add python and poetry plugin docs charmcraft merged PR #1940 merged as commit 408650c8, adding Python and Poetry plugin documentation (+144 lines, 6 files). Builds on #1939 (craft-parts common docs) and required craft-parts#872 anchors; merged despite12 unresolved review comments.
72%
#1510 fix(poetry): install export plugin on 25.04+ craft-parts merged Merged PR #1510 in commit 6d30ef14, adding python3-poetry-plugin-export on Ubuntu 25.04+ to preserve Poetry's export functionality.
72%
#2025 Poetry plugin: use parameters rather than env vars charmcraft closed Implemented parameter-based Poetry pip options in charmcraft#2044 (commit 0db15c18); the issue was later closed without a maintainer explanation.
72%
#1899 feat: add Python and Poetry plugins charmcraft merged Merged into main via commit 8b748f3e, adding Charmcraft-specific Python and Poetry plugins with charm-oriented venv, pip, source-copy, and binary defaults.
72%
#828 feat: tweaks to address user feedback before merging to main craft-parts closed PR #828 was closed unmerged after 767 days of inactivity; the Poetry plugin still uses poetry_with and --with, so its dependency-group export rework did not land.
72%