chore: split _get_java_post_build_commands
Metadata
Current evaluation
Merged after approval and passing CI. Fixed a broken /bin/java link for rockcraft projects by splitting the Java link command function, enabling plugin overrides. Resolves issue #813.
Suggested action: —
No scores available.
Issue body
JavaPlugin provides _get_java_post_build_commands() that is called from derived classes.
/bin/java link is broken for rockcraft projects.
Split _get_java_link_commands() into _get_java_link_commands() and _get_jar_link_commands() to allow rockcraft plugins override _get_java_link_commands().
This MR addresses https://github.com/canonical/craft-parts/issues/813
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. Fixed a broken /bin/java link for rockcraft projects by splitting the Java link command function, enabling plugin overrides. Resolves issue #813. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor splitting _get_java_link_commands() into distinct functions, enabling rockcraft plugins to override link behavior and fix a broken /bin/java symlink. Addresses issue #813. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2 chore(ci): add a workflow to build the rock | snapcraft-rocks | merged | Merged following reviewer approval. The change introduces a CI workflow to automate building the rock, adding a single configuration file with 21 lines. | |
| #858 chore: update the Jira project to ROCKCRAFT | rockcraft | merged | Merged after approval from two reviewers. Updated the Jira project configuration to ROCKCRAFT. CI checks passed. The change modified a single file. | |
| #5 chore(ci): upload built rock | snapcraft-rocks | merged | Merged a CI chore adding a script to upload the built rock artifact. The one-file change adds 16 lines, received approval from two reviewers, and was successfully integrated into the codebase. | |
| #752 feat: do not create /bin/java symlink | rockcraft | merged | Merged PR overrides maven and ant plugins to prevent creating a /bin/java symlink, resolving craft-parts issue #813 and enabling rock builds. Approved by two reviewers. Follow-up PR #916 handles documentation overrides. |