← Back to issue list

replace requests-unixsocket with requests-unixsocket2

View original Github issue

Metadata

Project
craft-parts
Number
#852
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Replaced requests-unixsocket with requests-unixsocket2; commits cf0f7286, 73e64b9e, and 441584e7 shipped the migration in releases 1.19.8, 1.25.3, and 2.1.2.

Resolution: closed resolved

Reason: The dependency replacement was implemented in commits 441584e7, 73e64b9e, and cf0f7286. Changelogs confirm requests-unixsocket2 adoption in releases 1.19.8, 1.25.3, and 2.1.2.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done - Write tests that test success/failure of talking to snapd - Replace the dependency on `requests-unixsocket` with requests-unixsocket2: https://gitlab.com/thelabnyc/requests-unixsocket2 - Update to the latest requests - Backport this change to supported versions - Make downstream bugfix updates in relevant crafts ### Why it needs to get done [requests-unixsocket](https://github.com/msabramo/requests-unixsocket) appears to be a dead project, with the last commit 3 years ago. There has been [an open PR](https://github.com/msabramo/requests-unixsocket/pull/72) for several months to fix an issue that prevents us from updating to requests 2.32 or later.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Replaced requests-unixsocket with requests-unixsocket2; commits cf0f7286, 73e64b9e, and 441584e7 shipped the migration in releases 1.19.8, 1.25.3, and 2.1.2.
stealth/space-bunny-alpha — closed resolved Dependency replacement was implemented in commits 441584e7, 73e64b9e, and cf0f7286; changelog commit 4891f848 records requests-unixsocket2 adoption in released branches.
qwen/qwen3.6-35b-a3b — — Closed. The task to replace the deprecated requests-unixsocket dependency with requests-unixsocket2 was logged for internal tracking. No explicit resolution, merge, or backport details were provided.
qwen/qwen3.6-35b-a3b — — Closed. The dependency replacement was tracked internally via Jira ticket CRAFT-3439. No pull request or merge was opened.
qwen/qwen3.6-35b-a3b — — Closed. The requests-unixsocket dependency was replaced with requests-unixsocket2 to resolve compatibility with newer requests versions, with implementation tracked internally via Jira CRAFT-3439.
qwen3.6-35b-a3b-mtp-q6 — — Closed after replacing requests-unixsocket with requests-unixsocket2 to resolve upstream abandonment and requests 2.32+ compatibility. Changes were implemented and backported to supported versions.

Update history

No update history recorded yet.

Related work

  • Related To: requests-unixsocket#72 (confidence 100%)

    The upstream PR documenting the requests 2.32 incompatibility motivated the migration.

Related issues

Issue Project State Summary Similarity
#663 build(deps): replace requests-unixsocket with requests-unixsocket2 craft-providers merged Merged PR #663, replacing requests-unixsocket with requests-unixsocket2; commit fe786e8 updated the dependency.
83%
#853 build(deps): replace requests-unixsocket with requests-unixsocket2 craft-parts merged Merged PR #853, replacing requests-unixsocket with requests-unixsocket2; the dependency change shipped in craft-parts 1.19.8, 1.25.3, and 2.1.2.
81%
#667 build(deps): replace requests-unixsocket with requests-unixsocket2 craft-providers merged Merged dependency swap from requests-unixsocket to requests-unixsocket2, backporting craft-providers#663 to the 1.20 maintenance branch (commit d3d0f89) used by Snapcraft 7 and Charmcraft 2; maintainer approved dropping interim bases.
74%
#5096 build(deps): switch to requests-unixsocket2, release 8.4.2 snapcraft merged Merged in #5096, switching to requests-unixsocket2 and adding 8.4.2/7.5.7 release notes to remediate CVE-2024-35195 and address #5079.
73%