← Back to issue list

build(deps): replace requests-unixsocket with requests-unixsocket2

View original Github issue

Metadata

Project
craft-providers
Number
#667
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged dependency swap from requests-unixsocket to requests-unixsocket2, backporting craft-providers#663 to the 1.20 maintenance branch (commit d3d0f89) used by Snapcraft 7 and Charmcraft 2; maintainer approved dropping interim bases.

Resolution: closed resolved

Reason: PR #667 was approved by two reviewers and merged as commit d3d0f89, which replaces requests-unixsocket with requests-unixsocket2 in the 1.20 branch. The review comment from lengau on 2024-10-02 confirms interim (non-LTS) bases were dropped rather than blocking.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- This backports the `requests-unixsocket2` change to 1.20, which is used by both Snapcraft 7 and Charmcraft 2

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged dependency swap from requests-unixsocket to requests-unixsocket2, backporting craft-providers#663 to the 1.20 maintenance branch (commit d3d0f89) used by Snapcraft 7 and Charmcraft 2; maintainer approved dropping interim bases.
qwen/qwen3.6-35b-a3b — closed resolved Merged dependency update replacing requests-unixsocket with requests-unixsocket2, backported to 1.20 for Snapcraft 7 and Charmcraft 2.

Update history

Date Change
created

Related work

  • Duplicate Of: canonical/craft-providers#663 (confidence 95%)

    Same change merged on the main branch (commit fe786e8); #667 is its backport to 1.20.

  • Related To: canonical/craft-parts#853 (confidence 70%)

    Parallel requests-unixsocket2 migration done in craft-parts (issue craft-parts#852), shipped in 1.19.8/1.25.3/2.1.2.

Related issues

Issue Project State Summary Similarity
#853 build(deps): replace requests-unixsocket with requests-unixsocket2 craft-parts merged Merged PR #853, replacing requests-unixsocket with requests-unixsocket2; the dependency change shipped in craft-parts 1.19.8, 1.25.3, and 2.1.2.
85%
#663 build(deps): replace requests-unixsocket with requests-unixsocket2 craft-providers merged Merged PR #663, replacing requests-unixsocket with requests-unixsocket2; commit fe786e8 updated the dependency.
81%
#856 chore: backport unixsocket -> unixsocket2 conversion to 1.19 for snapcraft 7 craft-parts merged Merged in #856, backporting the requests-unixsocket2 migration from #853 to craft-parts 1.19 for Snapcraft 7.
77%
#5088 Dependency updates for 7.5.6 snapcraft merged Merged #5088 for Snapcraft 7.5.6, updating internal dependencies and switching to requests-unixsocket2 to unblock the Requests upgrade.
77%
#852 replace requests-unixsocket with requests-unixsocket2 craft-parts closed Replaced requests-unixsocket with requests-unixsocket2; commits cf0f7286, 73e64b9e, and 441584e7 shipped the migration in releases 1.19.8, 1.25.3, and 2.1.2.
74%
#857 chore: backport unixsocket -> unixsocket2 to 1.25 for charmcraft craft-parts merged Merged PR #857 by lengau backported the requests-unixsocket -> requests-unixsocket2 swap (from #853/#856) onto the 1.25 hotfix branch for charmcraft; shipped in craft-parts 1.25.3.
72%
#649 build(deps): update dependency requests to <2.33 craft-providers closed Closed unmerged because requests 2.32 was incompatible with requests-unixsocket; Renovate ignored the <2.33 update pending a newer release.
72%
#143 build(deps): bump craft-providers to 1.20.0 craft-application merged Merged PR #143 as commit f0349036, updating craft-providers to 1.20.0 so host-injected snaps also receive their base snap.
71%
#4530 build(deps): bump craft-providers to 1.21.0 snapcraft merged Merged as commit ba4a2fb18: bumped craft-providers to 1.21.0 (base-v6 compat, Ubuntu 24.04 Noble support, dropped Mantic) as a prerequisite for snapcraft#4519; follow-up support landed in #4532.
71%
#5096 build(deps): switch to requests-unixsocket2, release 8.4.2 snapcraft merged Merged in #5096, switching to requests-unixsocket2 and adding 8.4.2/7.5.7 release notes to remediate CVE-2024-35195 and address #5079.
70%