fix(rust_plugin): fix dependency validation logic
Metadata
Current evaluation
Merged PR #903 fixed Rust dependency validation for rustup shims exiting 1 without a default toolchain, added two tests, and landed as dc79714c; fixes #890.
Resolution: closed resolved
Reason: PR #903 was merged and committed as dc79714c. The change corrected rustup-shim exit-code handling and added tests covering the new validation logic.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This pull request fixes the dependency validation logic regarding the "rust-deps" situation. If `rustup` is installed, then `cargo` and `rustc` will return an error code of `1` instead of `127` if no default toolchain is installed (because `cargo` and `rustc` will be shims generated by `rustup`).
Two more tests are added to verify this new validation logic.
Should fix #890.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #903 fixed Rust dependency validation for rustup shims exiting 1 without a default toolchain, added two tests, and landed as dc79714c; fixes #890. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-parts#903 in dc79714c, fixing rust-deps validation for rustup shims that exit 1 without a default toolchain and adding two tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for Rust dependency validation mishandling rustup exit codes. Updates logic to expect exit code 1 instead of 127 without a default toolchain, adds two tests, and resolves #890. Approved and merged directly without rebasing. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for Rust dependency validation logic to correctly handle rustup shim exit codes when no default toolchain is installed. Added two verification tests and resolved issue #890. Maintainer merged without requiring a rebase. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#890
(confidence 100%)
PR #903 explicitly states that its merged fix resolves issue #890.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #894 fix(plugins/rust): fix snap dependency handling | craft-parts | closed | PR #894 was superseded by #903, merged as dc79714c, correcting Rust plugin dependency validation and rustup installation behavior. | |
| #2434 rust plugin: refactor to use the latest rustup | snapcraft | merged | Merged PR #2434 in commit 3e821ca8d, updating the Rust plugin for current rustup, sharing toolchain storage, and adopting .cargo/config. | |
| #559 New rust plugin fails to validate with a `rust-deps` part dependency | craft-parts | closed | Fixed by merged PR canonical/craft-parts#560 (commit fbefe6b8), correcting Rust plugin validation when a rust-deps part dependency is present. |