fix(rust_plugin): fix dependency validation logic
Metadata
Current evaluation
Merged fix for Rust dependency validation mishandling rustup exit codes. Updates logic to expect exit code 1 instead of 127 without a default toolchain, adds two tests, and resolves #890. Approved and merged directly without rebasing.
Suggested action: —
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This pull request fixes the dependency validation logic regarding the "rust-deps" situation. If `rustup` is installed, then `cargo` and `rustc` will return an error code of `1` instead of `127` if no default toolchain is installed (because `cargo` and `rustc` will be shims generated by `rustup`).
Two more tests are added to verify this new validation logic.
Should fix #890.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for Rust dependency validation mishandling rustup exit codes. Updates logic to expect exit code 1 instead of 127 without a default toolchain, adds two tests, and resolves #890. Approved and merged directly without rebasing. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for Rust dependency validation logic to correctly handle rustup shim exit codes when no default toolchain is installed. Added two verification tests and resolved issue #890. Maintainer merged without requiring a rebase. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #570 rust_plugin: multiple fixes (#560) | craft-parts | merged | Merged as #560. The rust_plugin was updated to remove compiler plugins from final Snap packages and eliminate a redundant channel override causing type-checking errors. Approved by one reviewer and passed CI checks. |