← Back to issue list

fix(plugins/rust): fix snap dependency handling

View original Github issue

Metadata

Project
craft-parts
Number
#894
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #894 was superseded by #903, merged as dc79714c, correcting Rust plugin dependency validation and rustup installation behavior.

Resolution: closed superseded

Reason: PR #894 was closed unmerged after #903 replaced its changes. The replacement fix was merged in commit dc79714c.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This changes the following: - If 'rust-channel' is explicitly set to the string 'none', don't install rustup. - If the rust-using part has a 'rust-deps' plugin, don't install rustup. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #894 was superseded by #903, merged as dc79714c, correcting Rust plugin dependency validation and rustup installation behavior.
stealth/space-bunny-alpha — closed resolved Rust Snap dependency handling was fixed in #903 via commit dc79714c.
qwen/qwen3.6-35b-a3b — — Merged to fix snap dependency handling by skipping rustup installation when rust-channel is set to 'none' or the rust-deps plugin is present.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for snap dependency handling in the Rust plugin. Prevents rustup installation when rust-channel is set to none or the rust-deps plugin is present.

Update history

No update history recorded yet.

Related work

  • Superseded By: craft-parts#903 (confidence 99%)

    Merged replacement fixing Rust plugin rust-deps validation and rustup dependency handling.

Related issues

Issue Project State Summary Similarity
#903 fix(rust_plugin): fix dependency validation logic craft-parts merged Merged PR #903 fixed Rust dependency validation for rustup shims exiting 1 without a default toolchain, added two tests, and landed as dc79714c; fixes #890.
80%
#1774 fix(plugins/rust): don't require rustup when rust-deps is defined craft-parts merged Fixed a regression in the Rust plugin where rust-deps provisioning failed without rust-channel: none by removing the unnecessary rustup requirement. Merged in #1774.
73%
#579 Add new plugin: rust snapcraft merged Merged PR #579 as commit 24f1def33, adding Snapcraft's Rust plugin, resolving conflicts, and updating plugin-list test expectations.
72%
#570 rust_plugin: multiple fixes (#560) craft-parts merged Merged backport #570 (8d87e98e) of #560: the Rust plugin now removes compiler plugins from final Snaps and drops a redundant channel override.
71%
#2158 rust plugin: fix cargo builds and run tests snapcraft closed PR closed as superseded: the rust-plugin-improvements branch was deleted and the work was reworked and merged as snapcore/snapcraft#2170 (commit 4f80a1051) after cargo test broke cross-compilation.
70%
#2169 Rust plugin improvements snapcraft closed Closed unmerged and superseded by snapcraft#2170, merged as commit 4f80a1051 to fix Cargo builds and add Rust plugin tests.
70%