← Back to issue list

lifecycle: add part validator (CRAFT-367)

View original Github issue

Metadata

Project
craft-parts
Number
#93
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; shared part validation was later added through PR #277 as commit 67022699, replacing this lifecycle-specific approach.

Resolution: closed superseded

Reason: The maintainer closed the PR after simplifying validation and moving it to the application layer. A later implementation in PR #277 merged as commit 67022699 and added validate_part() to craft-parts.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Validate the given part data against the common parts model and the part's plugin model before creating the lifecycle manager. This allows the validation to happen on the host while the lifecycle manager is created later in a managed environment. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; shared part validation was later added through PR #277 as commit 67022699, replacing this lifecycle-specific approach.
stealth/space-bunny-alpha — closed superseded Closed unmerged: the maintainer simplified the validator and moved it to the application layer, so lifecycle validation was not added to craft-parts here.
qwen/qwen3.6-35b-a3b — — Superseded without merging. The validator was simplified and moved to the application layer instead of being added to craft-parts.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The proposed validator was superseded as functionality was simplified and relocated to the application layer instead of craft-parts.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#277 (confidence 97%)

    PR #277 later added shared validation for common and plugin part models and resolved issue #176.

  • Related To: canonical/craft-parts#176 (confidence 92%)

    This later issue requested a craft-parts validation helper and was resolved by PR #277.

Related issues

Issue Project State Summary Similarity
#277 parts: add part validator craft-parts merged Merged in #277 as commit 67022699, adding shared part and plugin model validation to the library and resolving #176.
75%
#25 parts: add PartsLifecycle support craft-application merged Merged PR #25 as commit 3fa6c712, adding PartsLifecycle support for CRAFT-1752 with tests and 100% diff coverage.
73%
#3636 parts: integrate craft-parts (CRAFT-765) snapcraft merged Merged as ae8467056, integrating craft-parts for project-part validation and parts lifecycle processing (CRAFT-765).
71%