← Back to issue list

parts: add PartsLifecycle support

View original Github issue

Metadata

Project
craft-application
Number
#25
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged into main following reviewer approval and passing CI. Adds PartsLifecycle support to the parts module, modifying 9 files with 100% test coverage. Addresses CRAFT-1752.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- CRAFT-1752

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main following reviewer approval and passing CI. Adds PartsLifecycle support to the parts module, modifying 9 files with 100% test coverage. Addresses CRAFT-1752.
qwen3.6-35b-a3b-mtp-q6 Merged into main, introducing PartsLifecycle support to the parts module. The update adds one file with 93 lines, achieves 100% test coverage, and resolves CRAFT-1752.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3636 parts: integrate craft-parts (CRAFT-765) snapcraft merged Merged after reviewer approval and passing CI checks. Integrates craft-parts for part validation and lifecycle processing. Modifies 12 files, adding 369 lines and removing 20, fulfilling CRAFT-765.
81%
#3 parts: add parts support (CRAFT-27) rockcraft merged Merged after approval. Integrates craft-parts to add initial parts processing support to Rockcraft. Changes span 11 files with 375 additions and 6 deletions. Zero unresolved comments and passing CI checks.
79%
#27 lifecycle: move PartsLifecycle to LifecycleService craft-application merged Merged after approval and CI checks. Relocated PartsLifecycle to LifecycleService to centralize business logic. Updated 9 files with 100% test coverage and no overall coverage impact.
77%
#3909 parts: use part validator from craft-parts snapcraft merged Merged into main. Replaced the local part validator with the shared craft-parts implementation, removing 119 lines across six files. Approved by reviewers, passed CI, and increased test coverage by 0.80%.
74%
#19 parts: add craftctl support rockcraft merged Merged after reviewer approval. Updated craft-parts to 1.4.1 and enabled craftctl support in step overrides across 16 files. Changes totaled +145/-66 lines. All CI checks passed with no unresolved comments.
73%
#294 docs: import Craft Parts documentation fragments rockcraft merged Merged after two reviewers approved and requested rebasing to sync with main. The change imports Craft Parts documentation fragments. CI passed, and preview confirms successful integration pending a Craft Parts release.
72%
#5332 docs: migrate 'parts lifecycle' snapcraft merged Merged documentation update migrating the parts lifecycle section. Approved by two reviewers, the change modifies five files with 272 additions and 27 deletions, integrating the updated content into the main branch.
72%
#3677 parts: add craftctl support snapcraft merged Merged following approval and passing CI. Implements a craftctl wrapper for craft-parts, defines project variables, and adds adopt-info to project configuration. Diff coverage is 84%.
72%
#850 docs: add references to lifecycle and part properties rockcraft open Docs PR adding lifecycle and part properties cross-references; 521 days old, changes requested with 4 unresolved comments, companion craft-parts PR rejected, docs since restructured to include these references via common craft-parts mechanism.
71%
#458 build: integrate craft-parts lifecycle (CRAFT-89, CRAFT-367, CRAFT-357) charmcraft merged Integrated the craft-parts lifecycle to execute the charm builder via a craft-parts charm build plugin. Merged after two approvals and passing CI checks. Author plans to refactor plugin-level transformations in a follow-up.
70%