← Back to issue list

Remove duplicated python-based plugin tests

View original Github issue

Metadata

Project
craft-parts
Number
#935
Type
issue
State
closed
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Duplicated Python plugin tests were consolidated into BasePythonPlugin coverage by merged PR #947 (commit 1a2631e1).

Resolution: closed resolved

Reason: PR #947 was merged as commit 1a2631e1, moving shared tests from the Python, Poetry, and UV plugin suites into BasePythonPlugin coverage and closing #935.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done The duplicated tests existing in the `python`, `poetry`, and `uv` plugin unit test suite should all get moved into a single test for `BasePythonPlugin` ### Why it needs to get done Duplicated tests are CO2 emission tests

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Duplicated Python plugin tests were consolidated into BasePythonPlugin coverage by merged PR #947 (commit 1a2631e1).
stealth/space-bunny-alpha — closed resolved Duplicated tests were consolidated into BasePythonPlugin coverage by merged PR #947 (commit 1a2631e1), removing 347 lines and adding 249.
stealth/space-bunny-alpha — closed resolved Merged PR #947 as commit 1a2631e1, consolidating duplicated python, poetry, and uv plugin tests into shared BasePythonPlugin test coverage.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to consolidate duplicated tests from python, poetry, and uv suites into a single BasePythonPlugin test was not acted upon. Only automated Jira sync comments were posted before closure.
qwen/qwen3.6-35b-a3b — — Consolidating duplicated Python plugin tests into a single BasePythonPlugin test was closed without resolution, effectively abandoned. No fix or merge occurred, with only automated Jira sync comments posted.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposal to consolidate duplicated tests across python, poetry, and uv plugins into a single BasePythonPlugin test was not addressed. Likely abandoned or superseded.
qwen3.6-35b-a3b-mtp-q6 — — Closed without resolution or merge. The request to consolidate duplicated plugin tests into a single BasePythonPlugin test was synced to internal Jira tickets but never implemented or addressed in this repository.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-parts#947 (confidence 100%)

    Merged PR #947 deduplicated the Python-based plugin tests and explicitly closed issue #935.

Related issues

Issue Project State Summary Similarity
#947 tests: deduplicate tests for python-based plugins craft-parts merged Merged PR #947 as commit 1a2631e1, consolidating duplicated Python plugin tests into BasePythonPlugin coverage and closing #935.
91%
#1603437 python2 plugin test coverage is lacking snapcraft (launchpad) closed Resolved by merged PR #663, “Improve python2 test coverage,” via commit 376c9e087.
73%
#1623289 Unify python plugin tests snapcraft (launchpad) closed Launchpad task to remove duplicated python2/python3 plugin tests was closed by maintainer sergiusens pointing to snapcore/snapcraft PR #793, which unified the test coverage.
72%
#1944 tests: split the plugins tests in the same directory snapcraft merged Merged PR #1944 in commit 2dd0377e9, consolidating split plugin test suites in one package so Python 3.6 unittest discovery no longer failed on directories missing __init__.py.
70%