tests: deduplicate tests for python-based plugins
Metadata
Current evaluation
Merged PR #947 as commit 1a2631e1, consolidating duplicated Python plugin tests into BasePythonPlugin coverage and closing #935.
Resolution: closed resolved
Reason: PR #947 was approved and merged as commit 1a2631e1. Its test refactor removed 347 lines while adding 249 across six files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
-----
Closes #935.
CRAFT-3807
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #947 as commit 1a2631e1, consolidating duplicated Python plugin tests into BasePythonPlugin coverage and closing #935. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #947 consolidated Python-based plugin tests, resolving #935 and CRAFT-3807 by removing 347 lines while adding 249 across six files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes that deduplicate tests for Python-based plugins, resolving #935 and CRAFT-3807. Approved by three reviewers, passed CI, and modified six files with a net reduction of 98 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged deduplication of tests for Python-based plugins, resolving issue #935 and ticket CRAFT-3807. Maintainer bepri integrated the changes without additional comments. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#935
(confidence 100%)
PR #947 explicitly closes the duplicate Python plugin test issue #935.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #935 Remove duplicated python-based plugin tests | craft-parts | closed | Duplicated Python plugin tests were consolidated into BasePythonPlugin coverage by merged PR #947 (commit 1a2631e1). | |
| #1944 tests: split the plugins tests in the same directory | snapcraft | merged | Merged PR #1944 in commit 2dd0377e9, consolidating split plugin test suites in one package so Python 3.6 unittest discovery no longer failed on directories missing __init__.py. | |
| #1791 tests: python plugin integration tests moved to a separate suite | snapcraft | merged | Merged PR #1791 (commit 91b6639f2) by come-maiz: Python plugin integration tests were moved out of the oversized plugins suite into their own suite, following the same split already done for catkin in #1760. | |
| #1266 tests: report coverage only in unit tests | snapcraft | merged | Merged PR #1266 as commit 0c64f0b31, restricting coverage reporting to unit tests and incorporating reviewer feedback for Python 2/3 compatibility. | |
| #1623289 Unify python plugin tests | snapcraft (launchpad) | closed | Launchpad task to remove duplicated python2/python3 plugin tests was closed by maintainer sergiusens pointing to snapcore/snapcraft PR #793, which unified the test coverage. |