← Back to issue list

feat: allow `devel` in multi-base charm builds

View original Github issue

Metadata

Project
craft-platforms
Number
#217
Type
pull request
State
open
Author
Copilot
Labels
Created
Updated
Closed

Current evaluation

Allow devel series in multi-base charm build-on entries. Approved by 2 reviewers with 10 unresolved comments, all CI passing, last activity 49 days ago.

Suggested action: needs review

Reason: PR has 2 approvals and passing CI but 10 unresolved review comments remain, indicating the review process is incomplete. Last activity was 49 days ago, so a maintainer should review the unresolved comments and decide whether to request changes or merge.

Impact: 50 Quick Win: 27.5 Staleness: 55 Complexity: 45 Confidence: 70

Issue body

- [x] Explore codebase and understand the issue - [x] Fix `_validate_base_definition` to allow `devel` series in `build-on` entries - [x] Fix `get_platforms_charm_build_plan` to use per-entry build base when present - [x] Add test cases for the new `devel` build-on functionality - [x] Update the hypothesis fuzz test filter to allow valid devel build-on cases - [x] Reject mixed devel+stable `build-on` (consistent with rejecting two different stable bases) - [x] Fix Hypothesis filter bugs: vectorise `build-on`/`build-for` scalars, reject mixed devel+stable within filter - [x] Fix linting issues: use `Set[Optional[str]]` for Python 3.8 compat, fix ruff format violations - [x] Reject devel+base-less mixing in `build-on` (base-less entries inherit a stable top-level base) - [x] Run tests (545/545 pass)

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 50
Quick Win: 27.5
Staleness: 55
Complexity: 45
Confidence: 70
needs review Allow devel series in multi-base charm build-on entries. Approved by 2 reviewers with 10 unresolved comments, all CI passing, last activity 49 days ago.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 35
Confidence: 90
needs review Allows devel series in multi-base charm build-on entries, updates validation and build plan logic, adds tests, and fixes linting. Approved by two reviewers, CI passing, and recently updated.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 45
Confidence: 90
needs review Adds support for devel series in multi-base charm builds by updating validation and build plan logic. Includes tests and addresses maintainer linting feedback. Currently awaiting review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 20
Complexity: 45
Confidence: 85
needs review Allows devel series in multi-base charm build-on entries. Updates validation, build plan logic, and tests. Addresses maintainer linting feedback; currently awaiting maintainer review.

Update history

No update history recorded yet.

Related work

  • Related To: craft-platforms#85 (confidence 95%)

    This PR implements the feature requested in issue #85 to allow devel in multi-base builds.

  • Related To: charmcraft#2507 (confidence 60%)

    Related issue in charmcraft about devel build-base failures, suggesting broader interest in devel support across the craft ecosystem.

Related issues

Issue Project State Summary Similarity
#85 Allow `devel` in multi-base builds craft-platforms open Enhancement to allow `devel` build bases in multi-base charm builds. Triaged with maintainer discussion on implementation approach.
85%
#598 feat: allow for multi-base builds craft-application merged Merged to enable multi-base builds by allowing bases in the platforms entry. Approved by three reviewers, passed CI, and resolves issue #569. Modified four files with 46 additions and 28 deletions.
75%
#2321 feat: add plucky and questing as devel bases charmcraft merged Merged after two approvals. Adds Ubuntu 25.04 and 25.10 as development bases for charm packing. Passed most CI checks, with known unrelated test failures deferred to PR #2320.
71%
#4068 meta: allow support for `build-base: devel` snapcraft merged Merged after approval and CI checks. Enables build-base: devel support and sets the grade to devel. A testing issue requiring manual apt update on the lunar image was resolved via a craft-providers update.
70%