fix: improve robustness of compatibility tag
Metadata
Current evaluation
Rejects instances with missing compatibility tags, centralizes config loading and error handling, and updates tests; lint and fast checks pass while five slow CI jobs remain pending.
Suggested action: needs review
Reason: The maintainer-authored change directly addresses #789 and its tests cover the missing-tag and shared-loading behavior. Lint, fast tests, minimum-dependency LXD tests, and CLA pass with no unresolved comments, but five slow CI jobs remain pending and the local test checklist is unchecked.
Evaluated by: mr-cal-bot
Impact:
52
Quick Win:
22
Complexity:
43
Confidence:
88
Actionability:
74
Issue body
Don't assume instance compatibility when the compatibility tag is
missing. Also refactor instance config loading into a shared method to
eliminate duplication and apply consistent error handling across
compatibility checks.
Fixes #789
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
52
Quick Win:
22
Complexity:
43
Confidence:
88
Actionability:
74
|
needs review | Rejects instances with missing compatibility tags, centralizes config loading and error handling, and updates tests; lint and fast checks pass while five slow CI jobs remain pending. | |
| stealth/space-bunny-alpha |
Impact:
46
Quick Win:
24
Complexity:
35
Confidence:
92
Actionability:
79
|
needs review | Rejects missing compatibility tags, shares instance-config loading, and standardizes compatibility-check errors. Open for 26 days, awaiting review; fast/minimum and LXD full tests pass, while slow jobs are pending. | |
| stealth/space-bunny-alpha |
Impact:
48
Quick Win:
25
Complexity:
34
Confidence:
86
Actionability:
78
|
needs review | Makes LXD compatibility checks treat a missing tag as unknown, consolidates instance config loading, and standardizes compatibility errors. All completed checks pass; slow tests remain pending. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
35
Quick Win:
19
Staleness:
15
Complexity:
45
Confidence:
65
|
needs review | PR improves compatibility tag handling by not assuming compatibility when tag is missing, refactors instance config loading into shared method with consistent error handling. Fresh PR (7 days old), passing CI, awaiting review. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Likely Fixed By:
craft-providers#789
(confidence 100%)
The PR explicitly says “Fixes #789”; the issue concerns missing, None, or empty compatibility tags being incorrectly accepted.
Related issues
No related issues found above the similarity threshold.