bases: fix bug in BuilddBase hostname validation logic
Metadata
Current evaluation
Merged PR #147 fixed BuilddBase hostname validation so trailing hyphens are removed from hostnames longer than 64 characters.
Resolution: closed resolved
Reason: PR #147 was approved and merged by maintainer mr-cal, correcting hostname handling for overlong values that could retain a trailing hyphen after truncation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
I made a mistake in hostname validation logic!
This fixes a bug where hostnames longer than 64 characters may not have trailing hyphens removed.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #147 fixed BuilddBase hostname validation so trailing hyphens are removed from hostnames longer than 64 characters. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Fixed hostname validation in BuilddBase to properly remove trailing hyphens from hostnames longer than 64 characters. Merged by mr-cal. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #136 bases: ensure BuilddBase hostname is valid | craft-providers | merged | Merged PR #136 as commit 1ba69d2, adding BuilddBase hostname validation and normalization. Follow-up PR #147 (acf9261) later corrected the validation logic. | |
| #247 bases: refactor buildd to ubuntu | craft-providers | merged | Merged PR #247 as de2d42e, replacing Buildd-specific base handling with Ubuntu-specific modules and preparing base dispatch for additional OS support. |