bases: ensure BuilddBase hostname is valid
Metadata
Current evaluation
Merged PR #136 as commit 1ba69d2, adding BuilddBase hostname validation and normalization. Follow-up PR #147 (acf9261) later corrected the validation logic.
Resolution: closed resolved
Reason: PR #136 was merged as commit 1ba69d2, implementing the intended BuilddBase hostname validation. Commit acf9261 in PR #147 subsequently fixed a bug in that validation logic.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This PR ensures that the `hostname` is valid, which was previously raising an error.
`BuilddBase`'s `hostname` parameter has similar naming conventions to [LXD instance names](https://github.com/canonical/craft-providers/pull/134). Yet, the naming convention is different enough that I didn't combine the functionality between the two.
(CRAFT-1234)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #136 as commit 1ba69d2, adding BuilddBase hostname validation and normalization. Follow-up PR #147 (acf9261) later corrected the validation logic. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR ensuring BuilddBase hostname is valid, fixing a previous validation error. Naming conventions are similar to LXD instance names but implemented separately. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/craft-providers#147
(confidence 100%)
Merged commit acf9261 fixed a bug in the hostname validation introduced by PR #136.
-
Related To:
canonical/craft-providers#134
(confidence 95%)
PR #136 explicitly referenced this LXD-compatible instance-name work while keeping hostname handling separate.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #147 bases: fix bug in BuilddBase hostname validation logic | craft-providers | merged | Merged PR #147 fixed BuilddBase hostname validation so trailing hyphens are removed from hostnames longer than 64 characters. | |
| #247 bases: refactor buildd to ubuntu | craft-providers | merged | Merged PR #247 as de2d42e, replacing Buildd-specific base handling with Ubuntu-specific modules and preparing base dispatch for additional OS support. | |
| #20 bases: introduce Buildd bases with support for 16.04, 18.04, and 20.04 | craft-providers | merged | Merged PR #20 by cjp256 landed as commit d6fae94, introducing Buildd bases (16.04/18.04/20.04) with deadline checks, os compatibility validation, and a FakeExecutor test fixture; follow-up work continued in PRs #24, #25, #26. |