executor: add mount method to base Executor class
Metadata
Current evaluation
Merged in #154 via commit 3844fe7, adding Executor.mount() and renaming LXDInstance.mount() to mount_with_device_name() to avoid overriding the inherited API.
Resolution: closed resolved
Reason: PR #154 was merged as commit 3844fe7, delivering the base Executor mount API and the corresponding LXD rename.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Add `mount()` method to base Executor class. This is required so applications can use these functions in the child classes. This is similar to https://github.com/canonical/craft-providers/pull/140.
LXD's mount method was renamed to make room for new inherited `mount` method while still allowing access to the old method.
`LXDInstance.mount(host_source, target, device_name)` is now `LXDInstance.mount_with_device_name(host_source, target, device_name)`
None of the *craft applications use the `device_name` parameter, so there should be no impact.
First usage will be in [rockcraft](https://github.com/canonical/rockcraft/pull/82).
(CRAFT-1383)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #154 via commit 3844fe7, adding Executor.mount() and renaming LXDInstance.mount() to mount_with_device_name() to avoid overriding the inherited API. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR adding a mount() method to the base Executor class and renaming LXD's mount to mount_with_device_name to allow inheritance. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
canonical/craft-providers#140
(confidence 99%)
Previously added exists() and delete() to the base Executor class in the same API series.
-
Related To:
canonical/rockcraft#82
(confidence 95%)
Identified in PR #154 as the first application expected to use the new inherited mount API.
Related issues
No related issues found above the similarity threshold.