← Back to issue list

providers: move mount logic to lifecycle.py

View original Github issue

Metadata

Project
rockcraft
Number
#82
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit f7ca0731 via #82, moving Rockcraft-specific project-directory mounting from craft-providers to lifecycle.py (CRAFT-1381).

Resolution: closed resolved

Reason: Approved PR #82 was merged as commit f7ca0731 after the upstream blocker was addressed, consolidating project-directory mounting in lifecycle.py.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Mounting the project directory is a rockcraft-specific step, so it is moved out of the craft-providers interface. Blocked by https://github.com/canonical/craft-providers/pull/154 (CRAFT-1381)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit f7ca0731 via #82, moving Rockcraft-specific project-directory mounting from craft-providers to lifecycle.py (CRAFT-1381).
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#82, moving Rockcraft-specific project-directory mount logic out of craft-providers and into lifecycle.py after the blocking craft-providers#154 change.
qwen/qwen3.6-35b-a3b — — Merged. Moved project directory mount logic from craft-providers to rockcraft's lifecycle.py, as it is rockcraft-specific. Approved, passed CI, and modified six files with a net reduction of 13 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Moved rockcraft-specific project directory mount logic from the craft-providers interface to lifecycle.py, fulfilling the dependency on craft-providers PR #154.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#3930 providers: move mount logic to lifecycle.py snapcraft merged Merged PR #3930 as commit 1c3a7eb92, moving Snapcraft-specific directory-mount calls from providers into parts/lifecycle.py for CRAFT-1397.
87%
#110 providers: move lxd project name out of craft-providers interface rockcraft merged Merged PR #110 (f72beac0), moving Rockcraft's LXD project name from lxd.py to providers.py and out of the craft-providers interface.
72%