← Back to issue list

bases: introduce Buildd bases with support for 16.04, 18.04, and 20.04

View original Github issue

Metadata

Project
craft-providers
Number
#20
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #20 by cjp256 landed as commit d6fae94, introducing Buildd bases (16.04/18.04/20.04) with deadline checks, os compatibility validation, and a FakeExecutor test fixture; follow-up work continued in PRs #24, #25, #26.

Resolution: closed resolved

Reason: The pull request was merged into main as commit d6fae94 ("bases: introduce Buildd bases with support for 16.04, 18.04, and 20.04"), confirmed by the merge commit 96a45cb "Merge pull request #20 from cjp256/buildd". The PR itself delivered the feature and its FakeExecutor test fixture, so it is closed as resolved.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The splattered _check_deadlines() is a little ugly, but deadlines are checked after every non-trivial operation. Perhaps future work can consider using something like stopit, but we don't really have any strict requirements for a timeout at the moment. Note that 16.04 is not supported on Windows with Multipass. - Add FakeExecutor fixture to simplify unit tests requiring executors. Paired with fake_subprocess, tests have a lot of control. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #20 by cjp256 landed as commit d6fae94, introducing Buildd bases (16.04/18.04/20.04) with deadline checks, os compatibility validation, and a FakeExecutor test fixture; follow-up work continued in PRs #24, #25, #26.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR introducing Buildd bases for Ubuntu 16.04, 18.04, and 20.04, plus a FakeExecutor fixture for unit tests.

Update history

Date Change
created

Related work

  • Related To: canonical/craft-providers#19 (confidence 90%)

    Preceding merge by the same author (dc82c81, 'bases: use BaseModel for InstanceConfiguration') that #20 builds on.

  • Related To: canonical/craft-providers#24 (confidence 80%)

    Follow-up buildd series adding os compatibility checks and instance configuration after the base foundation.

  • Related To: canonical/craft-providers#25 (confidence 70%)

    Follow-up buildd series renaming fields and adding compatibility-tag work building on the merged bases code.

  • Related To: canonical/craft-providers#26 (confidence 70%)

    Follow-up buildd instance-configuration refactor in the same post-merge series.

Related issues

Issue Project State Summary Similarity
#247 bases: refactor buildd to ubuntu craft-providers merged Merged PR #247 as de2d42e, replacing Buildd-specific base handling with Ubuntu-specific modules and preparing base dispatch for additional OS support.
78%
#36 project: support build-base and allow 'bare' bases rockcraft merged Merged in #36 as commit 5a27aca4, adding build-base, bare bases, and Ubuntu 22.04 support; follow-up commit d1a5f04c corrected a bare-base rebuild bug.
76%
#15 bases: introduce abstract Base and buildd implementation craft-providers closed Split into smaller changes: the abstract Base landed through merged PR #18 (commit a355b7e), while the oversized Base/buildd PR #15 was closed.
75%
#136 bases: ensure BuilddBase hostname is valid craft-providers merged Merged PR #136 as commit 1ba69d2, adding BuilddBase hostname validation and normalization. Follow-up PR #147 (acf9261) later corrected the validation logic.
73%