← Back to issue list

bases: refactor BaseAlias for extra OS support

View original Github issue

Metadata

Project
craft-providers
Number
#228
Type
pull request
State
closed
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

CentOS support was delivered through a separate CentOSBase architecture in merged PR #249 (commit a68d100), replacing the tuple-based BaseAlias approach.

Resolution: closed superseded

Reason: PR #228 was closed unmerged after review rejected the tuple-based generalization and requested a distinct CentOSBase. That alternative landed in canonical/craft-providers#249 at commit a68d100.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Change BaseAlias from str to tuple (OS, version) - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded CentOS support was delivered through a separate CentOSBase architecture in merged PR #249 (commit a68d100), replacing the tuple-based BaseAlias approach.
qwen/qwen3.6-35b-a3b — closed superseded BaseAlias refactor to tuple (OS, version) was closed after maintainer requested a different architecture for CentOS support, proposing a new CentOSBase class instead.

Update history

Date Change
created

Related work

Related issues

Issue Project State Summary Similarity
#256 bases: add CentOS 7 in get_base_from_alias() craft-providers merged Merged #256 in commit d48e185, adding CentOS 7 handling to get_base_from_alias().
80%