← Back to issue list

ci: fix TICS workflow failing on integration tests

View original Github issue

Metadata

Project
craft-providers
Number
#991
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 6c4b99c. Defaults PYTEST_ADDOPTS to exclude lxd_instance/multipass_instance for `make test-coverage` and installs Multipass in setup-tics, fixing TICS failures on the self-hosted runner.

Resolution: closed resolved

Reason: PR #991 was merged to main as commit 6c4b99c, adding marker filtering to the test-coverage target and Multipass to setup-tics. The author confirmed TICS run 29387447398 completed successfully afterwards, and all CI checks on the PR passed including 'TICS / TICS'.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The TICS workflow (`.github/workflows/tics.yaml`) runs `make test-coverage` on a self-hosted runner that doesn't have LXD or Multipass installed. Since `test-coverage` runs the full pytest suite with no marker filtering, it picks up integration tests marked `lxd_instance`/`multipass_instance`, which fail with `FileNotFoundError: multipass` etc. Fixes: https://github.com/canonical/craft-providers/actions/runs/29362672909/job/87186433705 ## Fix Default `PYTEST_ADDOPTS` to exclude these markers for the `test-coverage` target (only when not already set), mirroring how `qa.yaml`'s test jobs already filter markers via `PYTEST_ADDOPTS`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 6c4b99c. Defaults PYTEST_ADDOPTS to exclude lxd_instance/multipass_instance for `make test-coverage` and installs Multipass in setup-tics, fixing TICS failures on the self-hosted runner.
stealth/space-bunny-alpha — closed resolved Merged PR #991 updated TICS setup and test-coverage marker exclusions; follow-up run 29387447398 succeeded. Pre-existing integration-test flakes passed on retry.
qwen/qwen3.6-35b-a3b — — Merged fix for TICS CI workflow failing on integration tests. The runner lacked LXD and Multipass. Added PYTEST_ADDOPTS to exclude lxd_instance and multipass_instance markers during coverage runs. Approved and merged after passing all CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 15
Confidence: 90
needs review Fixes TICS CI workflow by excluding LXD/Multipass integration tests from coverage runs via PYTEST_ADDOPTS, matching existing qa.yaml behavior. Currently unreviewed and awaiting CI validation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-providers#741 (confidence 60%)

    Commit ee0a4f2 added the TICS workflow that PR #991 fixes; marker-filtering approach mirrors existing qa.yaml test jobs.

  • Related To: canonical/craft-providers#473 (confidence 40%)

    actionlint CI for GitHub Actions (e385e9d), adjacent to the workflow edits made here.

Related issues

Issue Project State Summary Similarity
#929 Multipass is needed for TICS coverage craft-providers open TICS workflow needed Multipass installed to run coverage. Resolved by merged PR #991 (6c4b99c), which added an install-multipass Makefile target wired into setup-tics; subsequent TICS run succeeded. Only the flaky multipass_instance test module remains excluded.
75%