fix: update discharge macaroons
Metadata
Current evaluation
Merged craft-store#212 as f2cd40d, updating discharge macaroons for Pydantic 2 alias behavior and fixing Snapcraft credential refresh (#5048).
Resolution: closed resolved
Reason: The approved PR was merged as commit f2cd40d. Its discharge-macaroon update works around Pydantic 2's inability to update aliased fields via model_copy(), fixing canonical/snapcraft#5048.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Pydantic 2's `model_copy()` function cannot update fields by their alias.
Fixes https://github.com/canonical/snapcraft/issues/5048
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-store#212 as f2cd40d, updating discharge macaroons for Pydantic 2 alias behavior and fixing Snapcraft credential refresh (#5048). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-store#212 (commit f2cd40d) updated discharge macaroons for Pydantic 2 alias handling, fixing credential refresh in snapcraft#5048. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-store#212 (f2cd40d), updating discharge macaroons to work around Pydantic 2 model_copy() not updating aliased fields; fixes snapcraft#5048. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-store#212 to update discharge macaroons after Pydantic 2 model_copy() stopped applying alias-based field updates, fixing snapcraft#5048. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for Pydantic 2 model_copy() alias update bug, resolving issue #5048. Approved by two reviewers, passed CI, and applied with 13 additions and 1 deletion across two files. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#5048
(confidence 100%)
Snapcraft credential-refresh failure explicitly fixed by this merged change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5048 Snapcraft 8.4 fails to refresh credentials | snapcraft | closed | Credential refresh was fixed in canonical/craft-store#212 (commit f2cd40d) by correcting a Pydantic 2 model_copy() alias regression affecting refreshed macaroons. | |
| #1621171 snapcraft doesn't refresh the macaroon | snapcraft (launchpad) | closed | Merged snapcore/snapcraft PR #805 as commit 60b7ef044, adding discharge-macaroon refresh so expired credentials are renewed and authorization errors are reduced. | |
| #1590813 snapcraft has a copy of pymacaroons code | snapcraft (launchpad) | closed | Vendored pymacaroons copy removed in favour of the xenial distro package, via ubuntu-core/snapcraft#584 (commit 28b94b375). SRU'd as snapcraft 2.12, verified by elopio and released to xenial-updates; bug closed verification-done. |