snapcraft has a copy of pymacaroons code
Metadata
Current evaluation
Vendored pymacaroons copy removed in favour of the xenial distro package, via ubuntu-core/snapcraft#584 (commit 28b94b375). SRU'd as snapcraft 2.12, verified by elopio and released to xenial-updates; bug closed verification-done.
Resolution: closed resolved
Reason: The linked PR ubuntu-core/snapcraft#584, merged as commit 28b94b375 "Switch from local copy to the proper python package", deleted the bundled pymacaroons code; the change was SRU'd in snapcraft 2.12 and elopio verified in xenial-proposed on 2016-06-28 before the SRU team released it to -updates.
Evaluated by: mr-cal-bot
No scores available.
Issue body
pymacaroons has just been released to xenial (thanks to cjwatson). So now we can import it and remove our copy.
[Impact]
* For users, none, the change should be transparent.
* For developers, less duplication and less complex code to maintain.
[Test Case]
* N/A. The duplicated file was removed, peer reviewed and all the tests kept passing.
[Regression Potential]
* commands that use macaroons authentication could start failing. But we are covered, the integration suite tests all the commands against the staging server.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Vendored pymacaroons copy removed in favour of the xenial distro package, via ubuntu-core/snapcraft#584 (commit 28b94b375). SRU'd as snapcraft 2.12, verified by elopio and released to xenial-updates; bug closed verification-done. | |
| stealth/space-bunny-alpha | — | closed resolved | Removed snapcraft's vendored pymacaroons copy by importing the distro package released to xenial. Fixed by merged PR canonical/snapcraft#584 and SRU'd as version 2.12, verified and released to xenial-updates. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/snapcraft#584 replaced snapcraft’s bundled pymacaroons code with the upstream package available in xenial, eliminating the duplicate implementation. | |
| qwen/qwen3.6-35b-a3b | — | — | Removed the duplicated pymacaroons code from snapcraft after upstream availability in xenial. The change was peer reviewed, passed all tests, and closed with verification completed. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by removing the duplicated pymacaroons code and switching to the system package after its xenial release. The change was peer reviewed, passed all tests, and verified with no user impact. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by removing the duplicated pymacaroons code copy now that the package is available in xenial. The change was peer reviewed, passed all tests, and verified, closing the issue. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by removing the duplicated pymacaroons code from snapcraft after the upstream package became available in xenial. The change was peer-reviewed, passed all tests, and verified, eliminating maintenance overhead. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed by removing the duplicated pymacaroons code and importing the upstream package now available in xenial. The change was peer-reviewed, passed all tests, and verified. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
ubuntu-core/snapcraft#584
(confidence 92%)
PR referenced twice in the bug comments; commit 28b94b375 carries the matching 'Switch from local copy to the proper python package' message.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #584 Use pymacaroons | snapcraft | merged | Merged canonical/snapcraft#584 in commit 28b94b375, replacing vendored pymacaroons with the packaged library; unit, integration, and snap tests passed. | |
| #212 fix: update discharge macaroons | craft-store | merged | Merged craft-store#212 as f2cd40d, updating discharge macaroons for Pydantic 2 alias behavior and fixing Snapcraft credential refresh (#5048). | |
| #1794703 undefined symbol: crypto_pwhash_argon2id_opslimit_moderate | snapcraft (launchpad) | closed | Fixed a pymacaroons dependency clash by removing obsolete pymacaroons-pynacl. Merged in snapcore/snapcraft#2302 (ff233cd72), with legacy fix #2303; confirmed working in edge 2.43.1+git52.gff233cd. |