chore: move tests to starflow
Metadata
Current evaluation
Merged canonical/craft-store#241, moving the test suite to Starflow. Follow-up canonical/starbase#300 fixed pre-commit invocation without a global installation.
Resolution: closed resolved
Reason: canonical/craft-store#241 was merged after two approvals, completing the Starflow test migration. Review follow-up canonical/starbase#300 merged as commit 55bf1ef to fix pre-commit invocation when it was not globally installed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This may be easiest to review per-commit, since there's a big autoformat in the middle that changes a lot of files.
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-store#241, moving the test suite to Starflow. Follow-up canonical/starbase#300 fixed pre-commit invocation without a global installation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #241 into craft-store, migrating its tests to canonical/starflow after review and two approvals. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the migration of tests to starflow after two approvals. Review raised library lockfile usage; the maintainer requested testing a follow-up fix in canonical/starbase#300. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and passing CI. Tests were relocated to starflow across 43 files, featuring a major autoformat pass. Minor lock file discussion preceded integration. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/starbase#300
(confidence 99%)
Directly requested during review; merged as 55bf1ef to address the lockfile-related pre-commit invocation problem.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #973 chore: merge the latest Starbase | craft-providers | merged | PR #973 merged as commit aa50a03, syncing canonical/starbase/main into craft-providers: 33 files, +1881/-316, approved by 2 reviewers; macos-14 large slow-test failure overridden. | |
| #434 chore(merge): update starbase (2026-10-08) | craft-store | closed | Merged routine maintenance update syncing craft-store to latest Starbase conventions, including CI workflows, build-system, and docs tooling updates. | |
| #5668 chore(merge): starbase into main | snapcraft | merged | Merged starbase into snapcraft main as commit 1a4c62e22 (SNAPCRAFT-1192), 3 files, +43/-37; approved by 2 reviewers. The single failing integration-spread-tests-store check was dismissed by the maintainer as unrelated. | |
| #387 chore(merge): update starbase (2026-06-18) | craft-store | merged | Merged PR #387 in commit 5c83549, updating Starbase docs/build tooling while preserving craft-store-specific CI and CODEOWNERS files. | |
| #219 chore(merge): update starbase (2026-10-13) | craft-grammar | closed | Merged routine starbase sync updating CI workflows, lint configs, and docs tooling to align with starbase/main. | |
| #377 chore(merge): update starbase | craft-store | merged | Merged Starbase updates into craft-store in commit 3c9f44f, bringing in changes accumulated since #337. | |
| #143 chore: migrate to starflow and Makefile | craft-archives | merged | Merged PR #143 migrated craft-archives to Starflow and Makefile tooling, resolving #146; it also included UV locking from canonical/starbase#322 and replaced yamllint with Prettier. | |
| #1722 chore: test starflow branch | craft-parts | closed | Throwaway PR 'chore: test starflow branch' by maintainer tigarmo (7 lines/1 file) to exercise a starflow-based branch. CI ran with many failing/pending jobs, then the PR was closed unmerged after ~17 days with 0 reviews, 0 comments and no changelog entry. | |
| #182 chore(merge): update starbase | craft-grammar | merged | Merged to main as commit 23557e7 (CRAFT-4762), pulling Starbase into Craft Grammar. Starbase's diff was favoured over the outdated local config; only type-check (ty) fixes were hand-written, plus docs review notes. | |
| #5419 chore(merge): merge starbase into main | snapcraft | merged | Merged the starbase branch into main via PR #5419 (commit e5752b8b3) for CRAFT-4322. It was an approved routine sync merge; the single failing Ubuntu24.04 spread test was acknowledged as a known 'craft test' issue. |