ci: pass staging username via vars in QA workflow
Metadata
Current evaluation
PR closed unmerged by lengau ("Superseded by branch pushed to canonical/craft-store with work/ prefix"). The same change landed as craft-store#393, merged as commit c4bbb1a, moving STAGING_SSO_USERNAME to workflow vars and keeping only the password in reusable-workflow secrets.
Resolution: closed superseded
Reason: The author closed #392 without merging, noting it was superseded by a work/ branch push. The identical change was submitted as canonical/craft-store#393 and merged as commit c4bbb1a, which passes the staging username via vars and reserves secret-1 for STAGING_SSO_PASSWORD.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
- apply the review suggestion from https://github.com/canonical/starflow/pull/156#discussion_r3461264550
- pass STAGING_SSO_USERNAME directly from workflow vars in extra-env-vars
- keep only STAGING_SSO_PASSWORD in reusable-workflow secrets (secret-1)
## Validation
- make lint-actions
- simulated reusable-workflow env expansion logic with one secret slot and direct username var
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR closed unmerged by lengau ("Superseded by branch pushed to canonical/craft-store with work/ prefix"). The same change landed as craft-store#393, merged as commit c4bbb1a, moving STAGING_SSO_USERNAME to workflow vars and keeping only the password in reusable-workflow secrets. | |
| stealth/space-bunny-alpha | — | closed superseded | PR unmerged and closed: same QA workflow change (staging SSO username via vars) was pushed to a work/ branch and landed as canonical/craft-store#393, merged as commit c4bbb1a. | |
| stealth/space-bunny-alpha | — | closed superseded | Unmerged; the QA workflow change was replaced by canonical/craft-store#393, merged as c4bbb1a, which passes the staging username through vars. | |
| qwen/qwen3.6-35b-a3b | — | — | Changes to pass the staging username via workflow variables were superseded. The modifications were moved to a work/ prefixed branch in the canonical/craft-store repository instead of being merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by a branch pushed to canonical/craft-store with a work/ prefix. The change intended to pass the staging SSO username via workflow variables instead of secrets to streamline the QA workflow. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-store#393
(confidence 96%)
Same title and intent; merged as commit c4bbb1a and is the surviving version of the change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #393 ci: pass staging username via vars in qa workflow | craft-store | merged | Merged in canonical/craft-store#393 (c4bbb1a), passing the staging username via workflow vars while reserving reusable-workflow secrets for the password. |