← Back to issue list

ci: pass staging username via vars in QA workflow

View original Github issue

Metadata

Project
craft-store
Number
#392
Type
pull request
State
closed
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Changes to pass the staging username via workflow variables were superseded. The modifications were moved to a work/ prefixed branch in the canonical/craft-store repository instead of being merged.

Suggested action:

No scores available.

Issue body

## Summary - apply the review suggestion from https://github.com/canonical/starflow/pull/156#discussion_r3461264550 - pass STAGING_SSO_USERNAME directly from workflow vars in extra-env-vars - keep only STAGING_SSO_PASSWORD in reusable-workflow secrets (secret-1) ## Validation - make lint-actions - simulated reusable-workflow env expansion logic with one secret slot and direct username var

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Changes to pass the staging username via workflow variables were superseded. The modifications were moved to a work/ prefixed branch in the canonical/craft-store repository instead of being merged.
qwen3.6-35b-a3b-mtp-q6 Superseded by a branch pushed to canonical/craft-store with a work/ prefix. The change intended to pass the staging SSO username via workflow variables instead of secrets to streamline the QA workflow.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#393 ci: pass staging username via vars in qa workflow craft-store merged Merged. Refactors the QA workflow to pass the staging username via variables instead of secrets, reserving secret slots for passwords. Approved by one reviewer and passed all CI checks.
86%