← Back to issue list

ci: pass staging username via vars in qa workflow

View original Github issue

Metadata

Project
craft-store
Number
#393
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-store#393 (c4bbb1a), passing the staging username via workflow vars while reserving reusable-workflow secrets for the password.

Resolution: closed resolved

Reason: PR #393 was approved and merged as commit c4bbb1a. It applies the review guidance from canonical/starflow#156 to pass the username through workflow variables and use secret slots only for the password.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Apply the review suggestion from [starflow/156](https://github.com/canonical/starflow/pull/156) by passing the username via workflow vars and using reusable-workflow secret slots only for the password. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-store#393 (c4bbb1a), passing the staging username via workflow vars while reserving reusable-workflow secrets for the password.
stealth/space-bunny-alpha — closed resolved Merged as canonical/craft-store#393 (commit c4bbb1a), passing the staging username through workflow vars and reserving reusable-workflow secrets for the password.
qwen/qwen3.6-35b-a3b — — Merged. Refactors the QA workflow to pass the staging username via variables instead of secrets, reserving secret slots for passwords. Approved by one reviewer and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated the QA workflow to pass the staging username via workflow variables instead of secrets, reserving secret slots for the password only. Applied review suggestion from PR #156 to improve CI credential handling.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starflow#156 (confidence 99%)

    Its review suggestion directly motivated the QA workflow changes in PR #393.

Related issues

Issue Project State Summary Similarity
#392 ci: pass staging username via vars in QA workflow craft-store closed PR closed unmerged by lengau ("Superseded by branch pushed to canonical/craft-store with work/ prefix"). The same change landed as craft-store#393, merged as commit c4bbb1a, moving STAGING_SSO_USERNAME to workflow vars and keeping only the password in reusable-workflow secrets.
92%