← Back to issue list

ci: pass staging username via vars in qa workflow

View original Github issue

Metadata

Project
craft-store
Number
#393
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged. Refactors the QA workflow to pass the staging username via variables instead of secrets, reserving secret slots for passwords. Approved by one reviewer and passed all CI checks.

Suggested action:

No scores available.

Issue body

Apply the review suggestion from [starflow/156](https://github.com/canonical/starflow/pull/156) by passing the username via workflow vars and using reusable-workflow secret slots only for the password. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Refactors the QA workflow to pass the staging username via variables instead of secrets, reserving secret slots for passwords. Approved by one reviewer and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated the QA workflow to pass the staging username via workflow variables instead of secrets, reserving secret slots for the password only. Applied review suggestion from PR #156 to improve CI credential handling.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#392 ci: pass staging username via vars in QA workflow craft-store closed Changes to pass the staging username via workflow variables were superseded. The modifications were moved to a work/ prefixed branch in the canonical/craft-store repository instead of being merged.
86%
#557 ci: set read permissions for qa workflow starbase merged Merged updates granting explicit read permissions to the QA workflow. This allows internal projects to run GitHub API-dependent actions like paths-filter. Approved by two reviewers with all CI checks passing.
70%