feat!: Disable `spread.yaml` fallback in `debcraft.Application`
Metadata
Current evaluation
PR debcraft#192 (approved, all CI green) set Application.allow_spread_yaml=False and raised craft-application floor to 7.3.0, but was closed unmerged; no replacement commit landed in debcraft.
Resolution: closed stale
Reason: The PR received2 approvals and passed all CI checks (fast/slow tests, lint, policy) but was closed without being merged, and no resolving commit or follow-up PR was recorded in debcraft. The originating issue debcraft#187 was also closed with the change tracked only by internal ticket DEBCRAFT-79.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Debcraft no longer needs backward compatibility for parsing `spread.yaml` now that test configuration has moved to `debcraft-test.yaml` in `craft-application` 7.3+. This change opts debcraft out of the legacy fallback and aligns its dependency floor with that behavior.
- **Application behavior**
- Set `Application.allow_spread_yaml = False` so debcraft only uses the current test config path.
```python
class Application(craft_application.Application):
allow_spread_yaml = False
```
- **Dependency alignment**
- Raise the minimum `craft-application` version to `7.3.0`, where the new config behavior is available.
- **Regression coverage**
- Add a focused application test asserting that `debcraft.Application` disables `spread.yaml` parsing.
<!-- START COPILOT CODING AGENT SUFFIX -->
- Fixes #187
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR debcraft#192 (approved, all CI green) set Application.allow_spread_yaml=False and raised craft-application floor to 7.3.0, but was closed unmerged; no replacement commit landed in debcraft. | |
| stealth/space-bunny-alpha | — | closed stale | Approved PR debcraft#192 implemented the change with green CI but closed unmerged; no replacement PR or commit was identified. | |
| stealth/space-bunny-alpha |
Impact:
42
Quick Win:
34
Complexity:
18
Confidence:
99
Actionability:
99
|
needs review | Disables legacy spread.yaml fallback in favor of debcraft-test.yaml, raises craft-application to 7.3+, and adds a regression test. Approved by two reviewers with all CI green; ready to merge. | |
| stealth/space-bunny-alpha |
Impact:
46
Quick Win:
38
Complexity:
16
Confidence:
97
Actionability:
99
|
needs review | Disables legacy spread.yaml configuration and requires craft-application 7.3, with a focused regression test; approved and all CI checks pass. | |
| stealth/space-bunny-alpha |
Impact:
35
Quick Win:
30
Complexity:
12
Confidence:
97
Actionability:
99
|
needs review | Disables legacy spread.yaml fallback, requires craft-application 7.3+, and adds regression coverage. Approved with all CI checks passing and no pending work. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
34
Complexity:
15
Confidence:
85
Actionability:
80
|
needs review | Disables deprecated spread.yaml fallback in debcraft.Application and raises craft-application dependency to >=7.3.0. CI passing, awaiting review. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/debcraft#187
(confidence 95%)
Originating issue the PR said it fixes; closed with no code change, tracked by internal DEBCRAFT-79.
-
Related To:
canonical/imagecraft#447
(confidence 60%)
Equivalent allow_spread_yaml/craft-application 7.3 change exists as an open PR in the sibling imagecraft project (issue imagecraft#429), not a debcraft resolution.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #447 feat!: Disable deprecated `spread.yaml` fallback in Imagecraft | imagecraft | merged | Merged PR disabling deprecated spread.yaml fallback: sets allow_spread_yaml=False, bumps craft-application to ~=7.3, refreshes lockfile, and adds a unit test. Fixes #429. | |
| #187 Set `Application.allow_spread_yaml` to false | debcraft | closed | Closed without a recorded code change; disabling spread.yaml compatibility remained tracked only by internal ticket DEBCRAFT-79. | |
| #429 Set `Application.allow_spread_yaml` to false | imagecraft | closed | Request to set Application.allow_spread_yaml=false after upgrading to craft-application 7.3+ remains unimplemented; issue closed without a resolving PR or code change. |