feat!: Disable deprecated `spread.yaml` fallback in Imagecraft
Metadata
Current evaluation
Merged PR disabling deprecated spread.yaml fallback: sets allow_spread_yaml=False, bumps craft-application to ~=7.3, refreshes lockfile, and adds a unit test. Fixes #429.
Resolution: closed resolved
Reason: PR #447 was merged after approval and conflict resolution. It implements issue #429 by setting allow_spread_yaml=False in AppMetadata and requiring craft-application ~=7.3.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Imagecraft no longer needs the backward-compatible `spread.yaml` parsing path introduced in `craft-application`. This updates the app to the first supporting release and explicitly opts out of the deprecated fallback.
- **Application metadata**
- Set `allow_spread_yaml=False` in `imagecraft`'s `AppMetadata` so `imagecraft test` no longer accepts `spread.yaml`.
- **Dependency alignment**
- Bump `craft-application` to `~=7.3`, where `allow_spread_yaml` is available.
- Refresh the lockfile to align transitive requirements introduced by that upgrade.
- **Regression coverage**
- Add a focused unit test asserting the application metadata keeps `spread.yaml` fallback disabled.
```python
APP_METADATA = AppMetadata(
name="imagecraft",
summary="A tool to create Ubuntu bootable images",
ProjectClass=project.Project,
enable_for_grammar=True,
check_supported_base=True,
allow_spread_yaml=False,
)
```
<!-- START COPILOT CODING AGENT SUFFIX -->
- Fixes #429
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed resolved | Merged PR disabling deprecated spread.yaml fallback: sets allow_spread_yaml=False, bumps craft-application to ~=7.3, refreshes lockfile, and adds a unit test. Fixes #429. | |
| ~deepseek/deepseek-pro-latest |
Impact:
50
Quick Win:
30
Complexity:
25
Confidence:
85
Actionability:
80
|
needs review | Sets allow_spread_yaml=False, bumps craft-application to ~=7.3, refreshes lockfile, adds metadata unit test; approved, conflicts resolved, CI pending. | |
| stealth/space-bunny-alpha |
Impact:
40
Quick Win:
25
Complexity:
28
Confidence:
76
Actionability:
88
|
needs review | Sets allow_spread_yaml=False in imagecraft AppMetadata, bumps craft-application to ~=7.3, refreshes lockfile, adds a metadata unit test. Approved by 2 reviewers, CLA green, conflicts resolved; fixes #429. | |
| stealth/space-bunny-alpha |
Impact:
45
Quick Win:
33
Complexity:
18
Confidence:
88
Actionability:
90
|
needs review | Disables deprecated spread.yaml fallback: sets allow_spread_yaml=False in AppMetadata, bumps craft-application to ~=7.3, refreshes lockfile, adds unit test. Fixes #429. Approved (2), CLA green, conflicts resolved. | |
| qwen/qwen3.8-27b |
Impact:
40
Quick Win:
31
Complexity:
15
Confidence:
90
Actionability:
90
|
needs review | Sets allow_spread_yaml=False in imagecraft's AppMetadata, bumps craft-application to ~=7.3, refreshes the lockfile, and adds a regression test. Approved by 2 reviewers, all CI green; merge conflicts resolved in bb81456. | |
| qwen/qwen3.8-27b |
Impact:
35
Quick Win:
13
Complexity:
15
Confidence:
85
Actionability:
45
|
keep open | Disables the deprecated spread.yaml fallback by setting allow_spread_yaml=False in imagecraft's AppMetadata, bumps craft-application to ~=7.3, refreshes the lockfile, and adds a regression test. Approved by 2 reviewers, CI green, but maintainer asked to resolve merge conflicts. | |
| qwen/qwen3.8-27b |
Impact:
35
Quick Win:
28
Complexity:
15
Confidence:
90
Actionability:
95
|
needs review | Disables the deprecated spread.yaml fallback for `imagecraft test` by setting allow_spread_yaml=False, bumps craft-application to ~=7.3, refreshes the lockfile, and adds a unit test. Approved by 2 reviewers, all CI checks passing. | |
| stealth/space-bunny-alpha |
Impact:
32
Quick Win:
23
Complexity:
14
Confidence:
82
Actionability:
85
|
needs review | Sets allow_spread_yaml=False in imagecraft's AppMetadata, bumps craft-application to ~=7.3, refreshes the lockfile and adds a unit test. Approved, CI green except three spread checks still pending. | |
| qwen/qwen3.6-35b-a3b |
Impact:
35
Quick Win:
18
Complexity:
15
Confidence:
75
Actionability:
60
|
needs review | Disables deprecated spread.yaml fallback by setting allow_spread_yaml=False and bumping craft-application to ~=7.3. PR is open with one failing CI check (conventional commits title format). |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
imagecraft#429
(confidence 100%)
PR body states Fixes #429.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #192 feat!: Disable `spread.yaml` fallback in `debcraft.Application` | debcraft | closed | PR debcraft#192 (approved, all CI green) set Application.allow_spread_yaml=False and raised craft-application floor to 7.3.0, but was closed unmerged; no replacement commit landed in debcraft. |