← Back to issue list

refactor: reorganize infrastructure for binary helpers

View original Github issue

Metadata

Project
debcraft
Number
#68
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 2fb3412, adding ELF stripping/shared-library handling and modularizing md5sums, control-file, and Debian package generation; it explicitly fixes #64.

Resolution: closed resolved

Reason: canonical/debcraft#68 merged as commit 2fb3412 with all reported CI checks passing and explicitly declared that it fixes #64. Follow-up work #72 and #73 subsequently reworked ELF handling and service organization.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit adds ELF file handling, used in helpers to strip ELF binaries and add shlibs to the control tarball. It also modularizes md5sums file creation, executing it along with other helpers at packaging time. Helper execution example: ``` Packing... Strip binary: /root/partitions/package/libpng16-16t64/prime/usr/lib/x86_64-linux-gnu/libpng16.so.16.43.0 Strip binary: /root/partitions/package/libpng-tools/prime/usr/bin/png-fix-itxt Strip binary: /root/partitions/package/libpng-tools/prime/usr/bin/pngfix ELF shared library: libpng16.so.16 Create control file for package libpng16-16t64 Create control file for package libpng-dev Create control file for package libpng-tools Create deb package libpng16-16t64_1.6.43-5build1_amd64.deb Create deb package libpng-dev_1.6.43-5build1_amd64.deb Create deb package libpng-tools_1.6.43-5build1_amd64.deb Packed: libpng16-16t64_1.6.43-5build1_amd64.deb, libpng-dev_1.6.43-5build1_amd64.deb, libpng-tools_1.6.43-5build1_amd64.deb ``` Fixes #64 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- DEBCRAFT-26

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 2fb3412, adding ELF stripping/shared-library handling and modularizing md5sums, control-file, and Debian package generation; it explicitly fixes #64.
stealth/space-bunny-alpha — closed resolved Merged as 2fb3412 via #68, adding ELF stripping/shared-library handling and modularizing md5sums, control, and deb generation.
qwen/qwen3.6-35b-a3b — — Merged following approval and passing CI. Refactored binary helper infrastructure to add ELF handling and modularize md5sums, control, and deb generation. Superseded by #72 and #73 for updated ELF support and service layout changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactor reorganizing binary helpers, adding ELF handling and modularizing md5sums, control, and deb generation. Subsequent comments note ELF support and service layout were superseded by PRs #72 and #73.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/debcraft#64 (confidence 100%)

    PR #68 explicitly states that it fixes issue #64.

  • Related To: canonical/debcraft#72 (confidence 98%)

    A maintainer noted that ELF support would be redone in #72; it landed through #75 at c841273.

  • Related To: canonical/debcraft#73 (confidence 98%)

    A maintainer noted that service layout would change in #73; it landed through #77 at 0b6d88e.

Related issues

No related issues found above the similarity threshold.