← Back to issue list

refactor: reorganize infrastructure for binary helpers

View original Github issue

Metadata

Project
debcraft
Number
#68
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged following approval and passing CI. Refactored binary helper infrastructure to add ELF handling and modularize md5sums, control, and deb generation. Superseded by #72 and #73 for updated ELF support and service layout changes.

Suggested action:

No scores available.

Issue body

This commit adds ELF file handling, used in helpers to strip ELF binaries and add shlibs to the control tarball. It also modularizes md5sums file creation, executing it along with other helpers at packaging time. Helper execution example: ``` Packing... Strip binary: /root/partitions/package/libpng16-16t64/prime/usr/lib/x86_64-linux-gnu/libpng16.so.16.43.0 Strip binary: /root/partitions/package/libpng-tools/prime/usr/bin/png-fix-itxt Strip binary: /root/partitions/package/libpng-tools/prime/usr/bin/pngfix ELF shared library: libpng16.so.16 Create control file for package libpng16-16t64 Create control file for package libpng-dev Create control file for package libpng-tools Create deb package libpng16-16t64_1.6.43-5build1_amd64.deb Create deb package libpng-dev_1.6.43-5build1_amd64.deb Create deb package libpng-tools_1.6.43-5build1_amd64.deb Packed: libpng16-16t64_1.6.43-5build1_amd64.deb, libpng-dev_1.6.43-5build1_amd64.deb, libpng-tools_1.6.43-5build1_amd64.deb ``` Fixes #64 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- DEBCRAFT-26

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval and passing CI. Refactored binary helper infrastructure to add ELF handling and modularize md5sums, control, and deb generation. Superseded by #72 and #73 for updated ELF support and service layout changes.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor reorganizing binary helpers, adding ELF handling and modularizing md5sums, control, and deb generation. Subsequent comments note ELF support and service layout were superseded by PRs #72 and #73.
qwen3.6-35b-a3b-mtp-q6 Merged refactoring of binary helper infrastructure, adding ELF handling and modularizing md5sums, control, and deb generation. Subsequently superseded by PRs #72 and #73, which reimplemented ELF support and updated service layout.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#75 refactor: rewrite elf file support debcraft merged Merged rewrite of ELF file support to better match deb building needs, replacing Snapcraft's implementation. Handles needed libraries; symbol support deferred. Approved by two reviewers, passed all CI checks, and resolves #72.
73%
#3840 elf: add handling and patching helpers snapcraft merged Merged into main following reviewer approval and passing CI checks. Introduces ELF binary listing and dynamic linker location helpers, adding handling and patching utilities to the elf module while increasing test coverage.
70%