← Back to issue list

Refactor ELF file handling

View original Github issue

Metadata

Project
debcraft
Number
#72
Type
issue
State
closed
Author
cmatsuoka
Labels
Status: Triaged
Created
Updated
Closed

Current evaluation

ELF handling was rewritten for Debcraft’s .deb workflow in merged PR #75 (commit c841273), replacing Snapcraft-derived code with shared-library dependency support; symbol handling was deferred.

Resolution: closed resolved

Reason: canonical/debcraft#75 was merged as c841273 and directly refactored ELF support to match the operations required for .deb builds.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The ELF file support copied from Snapcraft doesn't align with Debcraft needs. Refactor it or replace it with an implementation that better matches the operations required when dealing with shared library dependencies in .debs.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved ELF handling was rewritten for Debcraft’s .deb workflow in merged PR #75 (commit c841273), replacing Snapcraft-derived code with shared-library dependency support; symbol handling was deferred.
stealth/space-bunny-alpha — closed resolved ELF handling was refactored by merged PR #75 (commit c841273), replacing Snapcraft’s implementation with support tailored to .deb builds; symbol handling was deferred.
qwen/qwen3.6-35b-a3b — — Abandoned without resolution. The ELF file handling refactor request was superseded by internal Jira ticket DEBCRAFT-30. No code changes or merges were implemented.
qwen/qwen3.6-35b-a3b — — Requesting ELF file handling refactoring was closed and triaged, then synced to Jira as DEBCRAFT-30. No technical resolution or implementation details were documented.
qwen/qwen3.6-35b-a3b — — Closed and superseded by internal Jira ticket DEBCRAFT-30. The ELF file handling refactor was deferred to external tracking without a direct code fix or merge.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by internal Jira ticket DEBCRAFT-30. The ELF file handling refactor was moved off GitHub for internal tracking without code changes or a merge.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/debcraft#75 (confidence 100%)

    Merged ELF-support rewrite in commit c841273.

  • Related To: canonical/debcraft#104 (confidence 95%)

    Later added symbol-based shared-library dependencies in commit c70ce26, completing deferred symbol handling.

Related issues

Issue Project State Summary Similarity
#75 refactor: rewrite elf file support debcraft merged Merged as c841273, replacing Snapcraft-derived ELF handling with deb-oriented library dependency support. Symbol support was deferred to follow-up work.
86%
#1666 Refactor to support elf patching snapcraft closed ELF patching support was refactored by merged PR #1744 in commit ec7ba948a, converting the ELF implementation into reusable libraries.
73%
#3839 elf: add elf file handler class snapcraft merged PR #3839 was merged into main as commit 6830dc69c, porting the Snapcraft 6.x ElfFile handler into snapcraft/elf/_elf_file.py with helpers, ELF errors, and unit tests (CRAFT-1192).
72%
#1913 elf: pyelftools to parse ELF files rather than readelf snapcraft merged Merged PR #1913 (commit 9e4e88629): snapcraft.internal.elf.ElfFile now parses ELF files with pyelftools instead of shelling out to readelf, handling weak refs outside DT_NEEDED; cut test build times roughly in half.
70%