← Back to issue list

Refactor to support elf patching

View original Github issue

Metadata

Project
snapcraft
Number
#1666
Type
issue
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

ELF patching support was refactored by merged PR #1744 in commit ec7ba948a, converting the ELF implementation into reusable libraries.

Resolution: closed resolved

Reason: PR #1744 was merged as commit ec7ba948a with the title “elf: conversion from libraries,” providing the ELF refactor needed for patching support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Estimate: 2 days

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved ELF patching support was refactored by merged PR #1744 in commit ec7ba948a, converting the ELF implementation into reusable libraries.
stealth/space-bunny-alpha — closed stale ELF-patching refactor was closed with no comments or documented implementation, leaving its outcome unresolved.
qwen/qwen3.6-35b-a3b — — Refactoring to support elf patching was closed without implementation or discussion. No resolution or merge details were provided, indicating the task was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The elf patching refactoring task was abandoned, with zero comments, no linked pull request, and no resolution details provided.
qwen/qwen3.6-35b-a3b — — A requested refactor to support ELF patching was closed without implementation or discussion. With zero comments and no linked pull requests, the work was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned without implementation. The request to refactor code for ELF patching received no comments or activity and was closed.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#1744 (confidence 94%)

    The merged PR directly matches the requested ELF-support refactor and is indexed in connection with issue #1666.

Related issues

Issue Project State Summary Similarity
#3841 elf: add elf file patcher snapcraft merged Merged PR #3841 in commit e03a971b3, adding a patchelf-based ELF file patcher ported from Snapcraft 6.x for CRAFT-1191.
80%
#3985 elf: patch elf files for classic mode snapcraft merged Merged PR #3985 as commit a723254b9, adding classic-mode ELF patching so enable-patchelf parts use base-snap libraries or staged libc components.
77%
#1959 elf: only patch elf files that aren't referenced by DT_NEEDED snapcraft merged Merged as 64f78f762, adding architecture-aware DT_NEEDED filtering to reduce patchelf usage; PR #2081 later partially reverted it and restored patching every ELF file.
75%
#1979 pluginhandler: simplify logic when elf patching is required snapcraft merged Merged PR #1979 as commit 5fd7e3c30, simplifying pluginhandler ELF-patching detection and related tests across six files.
75%
#2081 elf: patch everything instead of a subset of elf files snapcraft merged Merged PR #2081 restored Snapcraft 2.39 behavior by patching every ELF file; commit 77770452b partially reverted 64f78f762a05.
74%
#3588 snap: patch patchelf on riscv64 (CRAFT-566) snapcraft merged Merged PR #3588 via commit bf99dbdb2, conditionally patching PatchELF on riscv64 while leaving other architectures unchanged.
74%
#75 refactor: rewrite elf file support debcraft merged Merged as c841273, replacing Snapcraft-derived ELF handling with deb-oriented library dependency support. Symbol support was deferred to follow-up work.
74%
#1798 elf: strip the .note.go.buildid to make room for patching elf snapcraft merged Merged #1798 in fa8b7b174, stripping Go ELF .note.go.buildid sections before patching and requiring newer patchelf header-layout support.
73%
#1888 elf: make patchelf a dependency snapcraft merged Merged PR #1888 via commit 7c947f5ec, moving Patchelf out of project_loader build tools and into the deb and snap delivery mechanisms.
73%
#1983 snap: update revision of patchelf to use snapcraft closed Closed unmerged; the bundled PatchELF revision bump in #1983 was superseded by #2006, which adopted packaging-based acquisition (commit aa2a40322).
73%