inspectors/snap: fix snap refresh inspector
Metadata
Current evaluation
Merged #145 (b12730c), fixing snap refresh inspection with stricter artifact validation, correct inspector naming, and inspector registration.
Resolution: closed resolved
Reason: PR #145 was merged as commit b12730c. It added stricter response-format verification, assigned the proper inspector name, and registered the snap refresh inspector.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fix the snap protocol refresh endpoint response inspector by adding
stricter verification of the artefact format and properly assigning
the inspector name.
Most importantly, register the snap refresh inspector.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #145 (b12730c), fixing snap refresh inspection with stricter artifact validation, correct inspector naming, and inspector registration. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/fetch-service#145 via commit b12730c, fixing snap refresh inspection with stricter artifact-format checks, correct naming, and registration. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI. The snap refresh inspector was fixed by enforcing stricter artifact format verification, correctly assigning the inspector name, and registering the component across nine files. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #84 inspectors: add snap inspectors | fetch-service | merged | Snap inspectors were added in merged PR #84, implemented by commit cfa83f8. | |
| #150 inspectors/snap: add additional inspector tests | fetch-service | merged | Merged PR #150 as commit 7e0b5b4, expanding test coverage for the Snap inspector after approval by two reviewers. | |
| #178 fix(inspectors/snap): minor inspector fixes and more test coverage | fetch-service | merged | Merged in PR #178 as commit 521b263, adding Snap inspector bounds checks, propagating SquashFS reader-creation errors, and broader tests. | |
| #513 Add snaps/name inspector | fetch-service | closed | Added the Snapcraft snap names inspector in merged PR #517 (commit 85f220e), resolving the LP test-build rejection. | |
| #176 fix(inspectors/snap): update valid urls | fetch-service | merged | Merged PR #176 fixed Snap download URL recognition in commit 576564b, resolving #155 by accepting the /api/v1/snaps/download URL. | |
| #407 Add inspector for snap sections | fetch-service | closed | Added and merged a Snap Store sections API inspector in PR #508 (commit a164101), preventing unrecognized-format inspection rejections. |