fix(inspectors/snap): minor inspector fixes and more test coverage
Metadata
Current evaluation
Merged in PR #178 as commit 521b263, adding Snap inspector bounds checks, propagating SquashFS reader-creation errors, and broader tests.
Resolution: closed resolved
Reason: PR #178 was approved and merged as commit 521b263, resolving the Snap inspector robustness gaps and improving test coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Guard against out of bounds access, return error if squashfs reader creation
fails, and improve test coverage.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #178 as commit 521b263, adding Snap inspector bounds checks, propagating SquashFS reader-creation errors, and broader tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/fetch-service#178 (commit 521b263), adding Snap inspector bounds checks, SquashFS reader error propagation, and expanded tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged Snap inspector fixes: guard out-of-bounds access, propagate SquashFS reader-creation errors, and expand test coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged minor snap inspector fixes, adding out-of-bounds access guards and error handling for squashfs reader creation. Improved test coverage. Approved by two reviewers and passed CI. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #150 inspectors/snap: add additional inspector tests | fetch-service | merged | Merged PR #150 as commit 7e0b5b4, expanding test coverage for the Snap inspector after approval by two reviewers. | |
| #84 inspectors: add snap inspectors | fetch-service | merged | Snap inspectors were added in merged PR #84, implemented by commit cfa83f8. | |
| #522 fix(inspectors/snap): fix serial assertion endpoint | fetch-service | merged | Merged PR #522 fixed the Snap serial-assertion endpoint in commit d374352; it received two approvals and passed all CI checks. | |
| #145 inspectors/snap: fix snap refresh inspector | fetch-service | merged | Merged #145 (b12730c), fixing snap refresh inspection with stricter artifact validation, correct inspector naming, and inspector registration. | |
| #544 fix(i/snap): don't reject non-snap squashfs files | fetch-service | merged | Merged PR #544 as commit e8bdea8, updating snap inspection to ignore non-snap SquashFS files instead of rejecting them; all CI checks passed. | |
| #87 inspectors/snap: ignore multi-line assertion entries | fetch-service | merged | Merged PR #87, making the snap inspector skip multi-line assertion entries, continue parsing later entries, and improve debugging and invalid-snap handling. | |
| #512 Add snaps/sections inspector | fetch-service | closed | Added the Snap Store sections API inspector in merged PR #508 (commit a164101), resolving the LP test-build rejection. | |
| #407 Add inspector for snap sections | fetch-service | closed | Added and merged a Snap Store sections API inspector in PR #508 (commit a164101), preventing unrecognized-format inspection rejections. | |
| #347 tests: reformat snap inspector test parameters | fetch-service | merged | Merged PR #347 as commit 51ce4ce, reformatting snap inspector test parameters across three files (+176/-74). | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests. |