fix(control): don't escape HTML in session report
Metadata
Current evaluation
Merged in fetch-service#167: session-report JSON no longer HTML-escapes characters such as <, > and &, preserving email addresses in angle brackets. Fixes #97.
Resolution: closed resolved
Reason: PR #167 was merged and introduced a JSON encoder configured with SetEscapeHTML(false) for session reports, resolving the metadata encoding problem reported in #97.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Go's JSON encoder escapes <, >, &, U+2028 and U+2029 characters inside
string literals by default, changing them to \u003c, \u003e, \u0026,
\u2028, \u2029. Disable this behavior when generating session reports
so that email addresses enclosed in <> will not be escaped.
Fixes #97
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in fetch-service#167: session-report JSON no longer HTML-escapes characters such as <, > and &, preserving email addresses in angle brackets. Fixes #97. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix disabled Go JSON HTML escaping in session reports, preserving <, >, &, U+2028 and U+2029; it fixes charmcraft#97. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix disabling Go's default JSON HTML escaping for session reports. This preserves email addresses in angle brackets. Approved by two reviewers, passed CI, rebased on main, and resolves #97. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
fetch-service#97
(confidence 100%)
PR #167 explicitly states that it fixes the HTML escaping issue reported in #97.
Related issues
No related issues found above the similarity threshold.