fetch-service should fail if `FETCH_APT_RELEASE_PUBLIC_KEY` is not set
Metadata
Current evaluation
Fixed in fetch-service 0.2.3 by commit c54c3fd, which makes initialization fail when FETCH_APT_RELEASE_PUBLIC_KEY is unset.
Resolution: closed resolved
Reason: Commit c54c3fd added the missing environment-variable validation, and the 0.2.3 changelog records the fix in the release dated 2024-10-03.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
Server initialization should fail if the `FETCH_APT_RELEASE_PUBLIC_KEY` env var is not set.
### Why it needs to get done
The fact that it doesn't fail right away makes debugging the session report difficult. For instance, this opinion:
```
"apt.release": {
"opinion": "Rejected",
"reason": "attempt to download packages file before Release",
"annotations": {
"architecture": "arm64",
"component": "universe",
"dist": "focal",
"origin": "http://ftpmaster.internal",
"repository": "http://ftpmaster.internal/ubuntu"
}
}
```
... is a consequence of the inspection of the corresponding `InRelease` file failing due to lack of public key:
```
"apt.release": {
"opinion": "Rejected",
"reason": "error parsing release file",
"annotations": {
"integrity errors": [
"signature verification failed: public key not found"
]
}
}
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Fixed in fetch-service 0.2.3 by commit c54c3fd, which makes initialization fail when FETCH_APT_RELEASE_PUBLIC_KEY is unset. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed in fetch-service commit c54c3fd by failing initialization when FETCH_APT_RELEASE_PUBLIC_KEY is unset. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The request to enforce missing FETCH_APT_RELEASE_PUBLIC_KEY validation was superseded by internal Jira ticket CRAFT-3518. No pull requests were merged. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #239 fix: properly set FETCH_APT_RELEASE_PUBLIC_KEY | fetch-service | merged | Merged in canonical/fetch-service#239: corrected ${SNAP} expansion and added fail-fast validation for FETCH_APT_RELEASE_PUBLIC_KEY; shipped in v0.2.3. |