← Back to issue list

fix: properly set FETCH_APT_RELEASE_PUBLIC_KEY

View original Github issue

Metadata

Project
fetch-service
Number
#239
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/fetch-service#239: corrected ${SNAP} expansion and added fail-fast validation for FETCH_APT_RELEASE_PUBLIC_KEY; shipped in v0.2.3.

Resolution: closed resolved

Reason: PR #239 was approved and merged, fixing the bash script’s SNAP substitution and detecting a missing public-key variable earlier. Commit c54c3fd records the safeguard, and the changelog lists the fix in v0.2.3.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The actual bug was the wrong `S{SNAP}` bit on the bash script; the rest of the change is adding code to try to capture that sort of issue a bit earlier.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/fetch-service#239: corrected ${SNAP} expansion and added fail-fast validation for FETCH_APT_RELEASE_PUBLIC_KEY; shipped in v0.2.3.
stealth/space-bunny-alpha — closed resolved Merged PR #239 fixed FETCH_APT_RELEASE_PUBLIC_KEY setup by correcting the bash script’s S{SNAP} bit and adding earlier error detection.
qwen/qwen3.6-35b-a3b — — Merged fix for FETCH_APT_RELEASE_PUBLIC_KEY. Corrected an incorrect S{SNAP} bit in a bash script and added early error detection. Approved by two reviewers. Modified 3 files with 33 additions and 3 deletions.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#238 fetch-service should fail if `FETCH_APT_RELEASE_PUBLIC_KEY` is not set fetch-service closed Fixed in fetch-service 0.2.3 by commit c54c3fd, which makes initialization fail when FETCH_APT_RELEASE_PUBLIC_KEY is unset.
78%
#71 fix: enable and update the apt release test fetch-service merged Merged in canonical/fetch-service#71; follow-up PR #75 (commit b9d7ce0) added missing APT release package-verification coverage after lint skipped the test run.
73%
#12 metadata: better apt release file detection fetch-service merged Merged in canonical/fetch-service#12 via commit 21b2d02, tightening APT release-file detection to prevent false positives for legacy Release files.
73%